Fix nameof(::Difference) error when printing basis objects from DMD fits #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SciML#563 The issue was that when displaying a Basis object containing Difference operators (as created by DMD algorithms), SymbolicUtils would try to call `nameof` on the Difference operator during display. However, unlike Differential which has `Base.nameof(D::Differential) = :Differential` defined in Symbolics/src/diff.jl, the Difference type was missing this method. This commit adds `Base.nameof(::Difference) = :Difference` to DataDrivenDiffEq as a workaround. This should ideally be upstreamed to Symbolics.jl. Also adds a regression test to ensure this doesn't regress. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Author
|
Closing this PR - the fix is type piracy. Moving the fix to Symbolics.jl where the Difference type is defined. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Base.nameof(::Difference) = :Differenceto fix display errors when printing Basis objects containing Difference operatorsnameofduring symbolic expression display, but unlikeDifferential, theDifferencetype was missing this method in Symbolics.jlChanges
Base.nameof(::Difference) = :Differenceinsrc/DataDrivenDiffEq.jlas a workaround (with a note that this should be upstreamed to Symbolics.jl)test/basis/basis.jlto ensure this doesn't regressTest plan
Pkg.test()locally - all 265 tests pass🤖 Generated with Claude Code