Bump OrdinaryDiffEqDifferentiation compat to 2.2.1#370
Closed
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
Closed
Bump OrdinaryDiffEqDifferentiation compat to 2.2.1#370ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
Conversation
Requires the fix for OOP J_t tracking in update_W! that prevents an infinite REDO loop in nlsolve.jl when using TRBDF2 with OOP DDEs. See SciML/OrdinaryDiffEq.jl#3107 Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing - the compat bump is already included in PR #369. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrdinaryDiffEqDifferentiationcompat from"2"to"2.2.1"to require the fix for OOPJ_ttracking inupdate_W!Context
OrdinaryDiffEqDifferentiation v2.2.1 (SciML/OrdinaryDiffEq.jl#3107) fixes a bug where OOP
update_W!only updatedJ_twhennew_jac=true, but OOPcalc_Walways recomputes J viacalc_J. Whendo_newJWreturned(new_jac=false, new_W=true),isJcurrent()returned false and triggered an infinite@goto REDOloop innlsolve.jl. This was exposed byqmax_first_step=10000in OrdinaryDiffEqCore 3.10.0 and manifested as hangs with OOP TRBDF2 DDEs (e.g., Hutchinson's equation).Test Plan
test/interface/jacobian.jl) is resolved by this version requirement🤖 Generated with Claude Code