Skip to content

Commit 042f08e

Browse files
Remove extra chainrulescore
1 parent b0bff41 commit 042f08e

File tree

2 files changed

+17
-18
lines changed

2 files changed

+17
-18
lines changed

ext/DiffEqBaseChainRulesCoreExt.jl

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,22 @@ import ChainRulesCore
77
import ChainRulesCore: NoTangent
88

99
ChainRulesCore.rrule(::typeof(numargs), f) = (numargs(f), df -> (NoTangent(), NoTangent()))
10+
ChainRulesCore.@non_differentiable checkkwargs(kwargshandle)
11+
12+
function ChainRulesCore.frule(::typeof(solve_up), prob,
13+
sensealg::Union{Nothing, AbstractSensitivityAlgorithm},
14+
u0, p, args...;
15+
kwargs...)
16+
_solve_forward(prob, sensealg, u0, p, SciMLBase.ChainRulesOriginator(), args...;
17+
kwargs...)
18+
end
19+
20+
function ChainRulesCore.rrule(::typeof(solve_up), prob::AbstractDEProblem,
21+
sensealg::Union{Nothing, AbstractSensitivityAlgorithm},
22+
u0, p, args...;
23+
kwargs...)
24+
_solve_adjoint(prob, sensealg, u0, p, SciMLBase.ChainRulesOriginator(), args...;
25+
kwargs...)
26+
end
1027

1128
end

src/solve.jl

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,8 +1051,6 @@ function checkkwargs(kwargshandle; kwargs...)
10511051
end
10521052
end
10531053

1054-
@non_differentiable checkkwargs(kwargshandle)
1055-
10561054
function get_concrete_problem(prob::AbstractJumpProblem, isadapt; kwargs...)
10571055
prob
10581056
end
@@ -1396,22 +1394,6 @@ discrete sensitivity algorithms.
13961394
"""
13971395
struct SensitivityADPassThrough <: AbstractDEAlgorithm end
13981396

1399-
function ChainRulesCore.frule(::typeof(solve_up), prob,
1400-
sensealg::Union{Nothing, AbstractSensitivityAlgorithm},
1401-
u0, p, args...;
1402-
kwargs...)
1403-
_solve_forward(prob, sensealg, u0, p, SciMLBase.ChainRulesOriginator(), args...;
1404-
kwargs...)
1405-
end
1406-
1407-
function ChainRulesCore.rrule(::typeof(solve_up), prob::AbstractDEProblem,
1408-
sensealg::Union{Nothing, AbstractSensitivityAlgorithm},
1409-
u0, p, args...;
1410-
kwargs...)
1411-
_solve_adjoint(prob, sensealg, u0, p, SciMLBase.ChainRulesOriginator(), args...;
1412-
kwargs...)
1413-
end
1414-
14151397
###
14161398
### Legacy Dispatches to be Non-Breaking
14171399
###

0 commit comments

Comments
 (0)