refactor: call get_updated_symbolic_problem in get_concrete_problem instead of init_call

Author: AayushSabharwal

src/solve.jl

@@ -547,7 +547,6 @@ function init_call(_prob, args...; merge_callbacks = true, kwargshandle = nothin
     kwargshandle = has_kwargs(_prob) && haskey(_prob.kwargs, :kwargshandle) ?
                    _prob.kwargs[:kwargshandle] : kwargshandle
 
-    _prob = get_updated_symbolic_problem(_get_root_indp(_prob), _prob)
     if has_kwargs(_prob)
         if merge_callbacks && haskey(_prob.kwargs, :callback) && haskey(kwargs, :callback)
             kwargs_temp = NamedTuple{
@@ -1240,28 +1239,32 @@ function checkkwargs(kwargshandle; kwargs...)
 end
 
 function get_concrete_problem(prob::AbstractJumpProblem, isadapt; kwargs...)
+    prob = get_updated_symbolic_problem(_get_root_indp(prob), prob)
     prob
 end
 
 function get_concrete_problem(prob::SteadyStateProblem, isadapt; kwargs...)
     p = get_concrete_p(prob, kwargs)
     u0 = get_concrete_u0(prob, isadapt, Inf, kwargs)
     u0 = promote_u0(u0, p, nothing)
-    remake(prob; u0 = u0, p = p)
+    prob = remake(prob; u0 = u0, p = p)
+    get_updated_symbolic_problem(_get_root_indp(prob), prob)
 end
 
 function get_concrete_problem(prob::NonlinearProblem, isadapt; kwargs...)
     p = get_concrete_p(prob, kwargs)
     u0 = get_concrete_u0(prob, isadapt, nothing, kwargs)
     u0 = promote_u0(u0, p, nothing)
-    remake(prob; u0 = u0, p = p)
+    prob = remake(prob; u0 = u0, p = p)
+    get_updated_symbolic_problem(_get_root_indp(prob), prob)
 end
 
 function get_concrete_problem(prob::NonlinearLeastSquaresProblem, isadapt; kwargs...)
     p = get_concrete_p(prob, kwargs)
     u0 = get_concrete_u0(prob, isadapt, nothing, kwargs)
     u0 = promote_u0(u0, p, nothing)
-    remake(prob; u0 = u0, p = p)
+    prob = remake(prob; u0 = u0, p = p)
+    get_updated_symbolic_problem(_get_root_indp(prob), prob)
 end
 
 function get_concrete_problem(prob::AbstractEnsembleProblem, isadapt; kwargs...)
@@ -1286,14 +1289,13 @@ function get_concrete_problem(prob, isadapt; kwargs...)
     tspan_promote = promote_tspan(u0_promote, p, tspan, prob, kwargs)
     f_promote = promote_f(prob.f, Val(SciMLBase.specialization(prob.f)), u0_promote, p,
         tspan_promote[1])
-    if isconcreteu0(prob, tspan[1], kwargs) && prob.u0 === u0 &&
+    if !(isconcreteu0(prob, tspan[1], kwargs) && prob.u0 === u0 &&
        typeof(u0_promote) === typeof(prob.u0) &&
        prob.tspan == tspan && typeof(prob.tspan) === typeof(tspan_promote) &&
-       p === prob.p && f_promote === prob.f
-        return prob
-    else
-        return remake(prob; f = f_promote, u0 = u0_promote, p = p, tspan = tspan_promote)
+       p === prob.p && f_promote === prob.f)
+        prob = remake(prob; f = f_promote, u0 = u0_promote, p = p, tspan = tspan_promote)
     end
+    get_updated_symbolic_problem(_get_root_indp(prob), prob)
 end
 
 function get_concrete_problem(prob::DAEProblem, isadapt; kwargs...)
@@ -1308,15 +1310,14 @@ function get_concrete_problem(prob::DAEProblem, isadapt; kwargs...)
 
     f_promote = promote_f(prob.f, Val(SciMLBase.specialization(prob.f)), u0_promote, p,
         tspan_promote[1])
-    if isconcreteu0(prob, tspan[1], kwargs) && typeof(u0_promote) === typeof(prob.u0) &&
+    if !(isconcreteu0(prob, tspan[1], kwargs) && typeof(u0_promote) === typeof(prob.u0) &&
        isconcretedu0(prob, tspan[1], kwargs) && typeof(du0_promote) === typeof(prob.du0) &&
        prob.tspan == tspan && typeof(prob.tspan) === typeof(tspan_promote) &&
-       p === prob.p && f_promote === prob.f
-        return prob
-    else
-        return remake(prob; f = f_promote, du0 = du0_promote, u0 = u0_promote, p = p,
+       p === prob.p && f_promote === prob.f)
+        prob = remake(prob; f = f_promote, du0 = du0_promote, u0 = u0_promote, p = p,
             tspan = tspan_promote)
     end
+    get_updated_symbolic_problem(_get_root_indp(prob), prob)
 end
 
 function get_concrete_problem(prob::DDEProblem, isadapt; kwargs...)
@@ -1333,7 +1334,8 @@ function get_concrete_problem(prob::DDEProblem, isadapt; kwargs...)
     u0 = promote_u0(u0, p, tspan[1])
     tspan = promote_tspan(u0, p, tspan, prob, kwargs)
 
-    remake(prob; u0 = u0, tspan = tspan, p = p, constant_lags = constant_lags)
+    prob = remake(prob; u0 = u0, tspan = tspan, p = p, constant_lags = constant_lags)
+    get_updated_symbolic_problem(_get_root_indp(prob), prob)
 end
 
 # Most are extensions