Skip to content

Commit 70f5d22

Browse files
prbzrgChrisRackauckas
authored andcommitted
replace deprecated types
1 parent e2183d9 commit 70f5d22

File tree

4 files changed

+37
-37
lines changed

4 files changed

+37
-37
lines changed

ext/DiffEqBaseReverseDiffExt.jl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,23 +76,23 @@ end
7676
end
7777

7878
# `ReverseDiff.TrackedArray`
79-
function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
79+
function DiffEqBase.solve_up(prob::DiffEqBase.AbstractDEProblem,
8080
sensealg::Union{
8181
SciMLBase.AbstractOverloadingSensitivityAlgorithm,
8282
Nothing}, u0::ReverseDiff.TrackedArray,
8383
p::ReverseDiff.TrackedArray, args...; kwargs...)
8484
ReverseDiff.track(DiffEqBase.solve_up, prob, sensealg, u0, p, args...; kwargs...)
8585
end
8686

87-
function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
87+
function DiffEqBase.solve_up(prob::DiffEqBase.AbstractDEProblem,
8888
sensealg::Union{
8989
SciMLBase.AbstractOverloadingSensitivityAlgorithm,
9090
Nothing}, u0, p::ReverseDiff.TrackedArray,
9191
args...; kwargs...)
9292
ReverseDiff.track(DiffEqBase.solve_up, prob, sensealg, u0, p, args...; kwargs...)
9393
end
9494

95-
function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
95+
function DiffEqBase.solve_up(prob::DiffEqBase.AbstractDEProblem,
9696
sensealg::Union{
9797
SciMLBase.AbstractOverloadingSensitivityAlgorithm,
9898
Nothing}, u0::ReverseDiff.TrackedArray, p,
@@ -101,7 +101,7 @@ function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
101101
end
102102

103103
# `AbstractArray{<:ReverseDiff.TrackedReal}`
104-
function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
104+
function DiffEqBase.solve_up(prob::DiffEqBase.AbstractDEProblem,
105105
sensealg::Union{
106106
SciMLBase.AbstractOverloadingSensitivityAlgorithm,
107107
Nothing},
@@ -112,7 +112,7 @@ function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
112112
kwargs...)
113113
end
114114

115-
function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
115+
function DiffEqBase.solve_up(prob::DiffEqBase.AbstractDEProblem,
116116
sensealg::Union{
117117
SciMLBase.AbstractOverloadingSensitivityAlgorithm,
118118
Nothing}, u0,
@@ -121,7 +121,7 @@ function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
121121
DiffEqBase.solve_up(prob, sensealg, u0, reduce(vcat, p), args...; kwargs...)
122122
end
123123

124-
function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
124+
function DiffEqBase.solve_up(prob::DiffEqBase.AbstractDEProblem,
125125
sensealg::Union{
126126
SciMLBase.AbstractOverloadingSensitivityAlgorithm,
127127
Nothing},

ext/DiffEqBaseTrackerExt.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,23 +67,23 @@ end
6767
end
6868
@inline DiffEqBase.ODE_DEFAULT_NORM(u::Tracker.TrackedReal, t::Tracker.TrackedReal) = abs(u)
6969

70-
function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
70+
function DiffEqBase.solve_up(prob::DiffEqBase.AbstractDEProblem,
7171
sensealg::Union{
7272
SciMLBase.AbstractOverloadingSensitivityAlgorithm,
7373
Nothing}, u0::Tracker.TrackedArray,
7474
p::Tracker.TrackedArray, args...; kwargs...)
7575
Tracker.track(DiffEqBase.solve_up, prob, sensealg, u0, p, args...; kwargs...)
7676
end
7777

78-
function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
78+
function DiffEqBase.solve_up(prob::DiffEqBase.AbstractDEProblem,
7979
sensealg::Union{
8080
SciMLBase.AbstractOverloadingSensitivityAlgorithm,
8181
Nothing}, u0::Tracker.TrackedArray, p, args...;
8282
kwargs...)
8383
Tracker.track(DiffEqBase.solve_up, prob, sensealg, u0, p, args...; kwargs...)
8484
end
8585

86-
function DiffEqBase.solve_up(prob::DiffEqBase.DEProblem,
86+
function DiffEqBase.solve_up(prob::DiffEqBase.AbstractDEProblem,
8787
sensealg::Union{
8888
SciMLBase.AbstractOverloadingSensitivityAlgorithm,
8989
Nothing}, u0, p::Tracker.TrackedArray, args...;

src/DiffEqBase.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,19 +48,19 @@ PrecompileTools.@recompile_invalidations begin
4848
import PreallocationTools
4949

5050
import FunctionWrappersWrappers
51-
51+
5252
using SciMLBase
5353

5454
using SciMLOperators: AbstractSciMLOperator, AbstractSciMLScalarOperator
5555

56-
using SciMLBase: @def, DEIntegrator, DEProblem,
56+
using SciMLBase: @def, DEIntegrator, AbstractDEProblem,
5757
AbstractDiffEqInterpolation,
5858
DECallback, AbstractDEOptions, DECache, AbstractContinuousCallback,
5959
AbstractDiscreteCallback, AbstractLinearProblem, AbstractNonlinearProblem,
6060
AbstractOptimizationProblem, AbstractSteadyStateProblem,
6161
AbstractJumpProblem,
6262
AbstractNoiseProblem, AbstractEnsembleProblem, AbstractDynamicalODEProblem,
63-
DEAlgorithm, StandardODEProblem, AbstractIntegralProblem,
63+
AbstractDEAlgorithm, StandardODEProblem, AbstractIntegralProblem,
6464
AbstractSensitivityAlgorithm, AbstractODEAlgorithm,
6565
AbstractSDEAlgorithm, AbstractDDEAlgorithm, AbstractDAEAlgorithm,
6666
AbstractSDDEAlgorithm, AbstractRODEAlgorithm, DAEInitializationAlgorithm,

src/solve.jl

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ NO_TSPAN_PROBS = Union{AbstractLinearProblem, AbstractNonlinearProblem,
77
AbstractIntegralProblem, AbstractSteadyStateProblem,
88
AbstractJumpProblem}
99

10-
has_kwargs(_prob::DEProblem) = has_kwargs(typeof(_prob))
10+
has_kwargs(_prob::AbstractDEProblem) = has_kwargs(typeof(_prob))
1111
Base.@pure __has_kwargs(::Type{T}) where {T} = :kwargs fieldnames(T)
1212
has_kwargs(::Type{T}) where {T} = __has_kwargs(T)
1313

@@ -196,7 +196,7 @@ end
196196
const NON_SOLVER_MESSAGE = """
197197
The arguments to solve are incorrect.
198198
The second argument must be a solver choice, `solve(prob,alg)`
199-
where `alg` is a `<: DEAlgorithm`, e.g. `Tsit5()`.
199+
where `alg` is a `<: AbstractDEAlgorithm`, e.g. `Tsit5()`.
200200
201201
Please double check the arguments being sent to the solver.
202202
@@ -484,7 +484,7 @@ function init_call(_prob, args...; merge_callbacks = true, kwargshandle = nothin
484484
end
485485
end
486486

487-
function init(prob::Union{DEProblem, NonlinearProblem}, args...; sensealg = nothing,
487+
function init(prob::Union{AbstractDEProblem, NonlinearProblem}, args...; sensealg = nothing,
488488
u0 = nothing, p = nothing, kwargs...)
489489
if sensealg === nothing && haskey(prob.kwargs, :sensealg)
490490
sensealg = prob.kwargs[:sensealg]
@@ -500,7 +500,7 @@ function init(prob::AbstractJumpProblem, args...; kwargs...)
500500
init_call(prob, args...; kwargs...)
501501
end
502502

503-
function init_up(prob::DEProblem, sensealg, u0, p, args...; kwargs...)
503+
function init_up(prob::AbstractDEProblem, sensealg, u0, p, args...; kwargs...)
504504
alg = extract_alg(args, kwargs, prob.kwargs)
505505
if isnothing(alg) # Default algorithm handling
506506
_prob = get_concrete_problem(prob, !(typeof(prob) <: DiscreteProblem); u0 = u0,
@@ -566,7 +566,7 @@ mutable struct NullODEIntegrator{IIP, ProbType, T, SolType, F, P} <:
566566
f::F
567567
p::P
568568
end
569-
function build_null_integrator(prob::DEProblem, args...;
569+
function build_null_integrator(prob::AbstractDEProblem, args...;
570570
kwargs...)
571571
sol = solve(prob, args...; kwargs...)
572572
return NullODEIntegrator{isinplace(prob), typeof(prob), eltype(prob.tspan), typeof(sol),
@@ -592,7 +592,7 @@ function step!(integ::NullODEIntegrator, dt = nothing, stop_at_tdt = false)
592592
return nothing
593593
end
594594

595-
function build_null_solution(prob::DEProblem, args...;
595+
function build_null_solution(prob::AbstractDEProblem, args...;
596596
saveat = (),
597597
save_everystep = true,
598598
save_on = true,
@@ -635,7 +635,7 @@ end
635635

636636
"""
637637
```julia
638-
solve(prob::DEProblem, alg::Union{DEAlgorithm,Nothing}; kwargs...)
638+
solve(prob::AbstractDEProblem, alg::Union{AbstractDEAlgorithm,Nothing}; kwargs...)
639639
```
640640
641641
## Arguments
@@ -914,7 +914,7 @@ the extension to other types is straightforward.
914914
to save size or because the user does not care about the others. Finally, with
915915
`progress = true` you are enabling the progress bar.
916916
"""
917-
function solve(prob::DEProblem, args...; sensealg = nothing,
917+
function solve(prob::AbstractDEProblem, args...; sensealg = nothing,
918918
u0 = nothing, p = nothing, wrap = Val(true), kwargs...)
919919
if sensealg === nothing && haskey(prob.kwargs, :sensealg)
920920
sensealg = prob.kwargs[:sensealg]
@@ -987,8 +987,8 @@ function solve(prob::NonlinearProblem, args...; sensealg = nothing,
987987
end
988988
end
989989

990-
function solve_up(prob::Union{DEProblem, NonlinearProblem}, sensealg, u0, p, args...;
991-
kwargs...)
990+
function solve_up(prob::Union{AbstractDEProblem, NonlinearProblem}, sensealg, u0, p,
991+
args...; kwargs...)
992992
alg = extract_alg(args, kwargs, prob.kwargs)
993993
if isnothing(alg) # Default algorithm handling
994994
_prob = get_concrete_problem(prob, !(typeof(prob) <: DiscreteProblem); u0 = u0,
@@ -1070,12 +1070,12 @@ function get_concrete_problem(prob::AbstractEnsembleProblem, isadapt; kwargs...)
10701070
prob
10711071
end
10721072

1073-
function solve(prob::PDEProblem, alg::DiffEqBase.DEAlgorithm, args...;
1073+
function solve(prob::PDEProblem, alg::AbstractDEAlgorithm, args...;
10741074
kwargs...)
10751075
solve(prob.prob, alg, args...; kwargs...)
10761076
end
10771077

1078-
function init(prob::PDEProblem, alg::DiffEqBase.DEAlgorithm, args...;
1078+
function init(prob::PDEProblem, alg::AbstractDEAlgorithm, args...;
10791079
kwargs...)
10801080
init(prob.prob, alg, args...; kwargs...)
10811081
end
@@ -1266,27 +1266,27 @@ handle_distribution_u0(_u0) = _u0
12661266
eval_u0(u0::Function) = true
12671267
eval_u0(u0) = false
12681268

1269-
function __solve(prob::DEProblem, args...; default_set = false, second_time = false,
1269+
function __solve(prob::AbstractDEProblem, args...; default_set = false, second_time = false,
12701270
kwargs...)
12711271
if second_time
12721272
throw(NoDefaultAlgorithmError())
1273-
elseif length(args) > 0 && !(typeof(args[1]) <: Union{Nothing, DEAlgorithm})
1273+
elseif length(args) > 0 && !(typeof(args[1]) <: Union{Nothing, AbstractDEAlgorithm})
12741274
throw(NonSolverError())
12751275
else
1276-
__solve(prob::DEProblem, nothing, args...; default_set = false, second_time = true,
1277-
kwargs...)
1276+
__solve(prob::AbstractDEProblem, nothing, args...; default_set = false,
1277+
second_time = true, kwargs...)
12781278
end
12791279
end
12801280

1281-
function __init(prob::DEProblem, args...; default_set = false, second_time = false,
1281+
function __init(prob::AbstractDEProblem, args...; default_set = false, second_time = false,
12821282
kwargs...)
12831283
if second_time
12841284
throw(NoDefaultAlgorithmError())
1285-
elseif length(args) > 0 && !(typeof(args[1]) <: Union{Nothing, DEAlgorithm})
1285+
elseif length(args) > 0 && !(typeof(args[1]) <: Union{Nothing, AbstractDEAlgorithm})
12861286
throw(NonSolverError())
12871287
else
1288-
__init(prob::DEProblem, nothing, args...; default_set = false, second_time = true,
1289-
kwargs...)
1288+
__init(prob::AbstractDEProblem, nothing, args...; default_set = false,
1289+
second_time = true, kwargs...)
12901290
end
12911291
end
12921292

@@ -1360,7 +1360,7 @@ Ignores all adjoint definitions (i.e. `sensealg`) and proceeds to do standard
13601360
AD through the `solve` functions. Generally only used internally for implementing
13611361
discrete sensitivity algorithms.
13621362
"""
1363-
struct SensitivityADPassThrough <: SciMLBase.DEAlgorithm end
1363+
struct SensitivityADPassThrough <: AbstractDEAlgorithm end
13641364

13651365
function ChainRulesCore.frule(::typeof(solve_up), prob,
13661366
sensealg::Union{Nothing, AbstractSensitivityAlgorithm},
@@ -1370,7 +1370,7 @@ function ChainRulesCore.frule(::typeof(solve_up), prob,
13701370
kwargs...)
13711371
end
13721372

1373-
function ChainRulesCore.rrule(::typeof(solve_up), prob::SciMLBase.DEProblem,
1373+
function ChainRulesCore.rrule(::typeof(solve_up), prob::AbstractDEProblem,
13741374
sensealg::Union{Nothing, AbstractSensitivityAlgorithm},
13751375
u0, p, args...;
13761376
kwargs...)
@@ -1382,8 +1382,8 @@ end
13821382
### Legacy Dispatches to be Non-Breaking
13831383
###
13841384

1385-
@deprecate concrete_solve(prob::SciMLBase.DEProblem,
1386-
alg::Union{SciMLBase.DEAlgorithm, Nothing},
1385+
@deprecate concrete_solve(prob::AbstractDEProblem,
1386+
alg::Union{AbstractDEAlgorithm, Nothing},
13871387
u0 = prob.u0, p = prob.p, args...; kwargs...) solve(prob, alg,
13881388
args...;
13891389
u0 = u0,
@@ -1459,7 +1459,7 @@ end
14591459
else
14601460
nothing
14611461
end
1462-
elseif solve_args[1] isa DEAlgorithm
1462+
elseif solve_args[1] isa AbstractDEAlgorithm
14631463
solve_args[1]
14641464
else
14651465
nothing

0 commit comments

Comments
 (0)