Skip to content

Commit b723fe8

Browse files
Improve Downstream testing
SciML/SciMLSensitivity.jl#1189 highlights that the downstream tests that are failing for SciMLSensitivity.jl are actually Enzyme issues with v1.11. These are now being tracked here EnzymeAD/Enzyme.jl#2318 for the Enzyme developers to work on. But there are certain things we've been weary about, like: * SciML/SciMLBase.jl#997 * SciML/SciMLBase.jl#998 Because of failing downstream tests. But that's counter productive: we're not improving our autodiff interfaces because we see failures, but those aren't failures of our autodiff interfaces, those are Enzyme failures. So for now the solution seems to be to go to v1.10 in these downstream tests and increase the coverage of SciMLSensitivity, and focus on our parts. We can re-enable "1" when Enzyme is ready for it, but for now it's just noise.
1 parent a665e64 commit b723fe8

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/workflows/Downstream.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
strategy:
1919
fail-fast: false
2020
matrix:
21-
julia-version: [1]
21+
julia-version: ['1.10']
2222
os: [ubuntu-latest]
2323
package:
2424
- {user: SciML, repo: DelayDiffEq.jl, group: Interface}
@@ -49,6 +49,9 @@ jobs:
4949
- {user: SciML, repo: SciMLSensitivity.jl, group: Core3}
5050
- {user: SciML, repo: SciMLSensitivity.jl, group: Core4}
5151
- {user: SciML, repo: SciMLSensitivity.jl, group: Core5}
52+
- {user: SciML, repo: SciMLSensitivity.jl, group: Core6}
53+
- {user: SciML, repo: SciMLSensitivity.jl, group: Core7}
54+
- {user: SciML, repo: SciMLSensitivity.jl, group: Core8}
5255
- {user: SciML, repo: SciMLSensitivity.jl, group: SDE1}
5356
- {user: SciML, repo: SciMLSensitivity.jl, group: SDE2}
5457
- {user: SciML, repo: SciMLSensitivity.jl, group: SDE3}

0 commit comments

Comments
 (0)