Merge pull request #1199 from AayushSabharwal/as/better-disc-save

feat: save discretes alongside callback save

Author: ChrisRackauckas

Project.toml

@@ -94,7 +94,7 @@ Printf = "1.9"
 RecursiveArrayTools = "3.1"
 Reexport = "1.0"
 ReverseDiff = "1"
-SciMLBase = "2.114.0"
+SciMLBase = "2.115.0"
 SciMLOperators = "1"
 SciMLStructures = "1.5"
 Setfield = "1"

src/callbacks.jl

@@ -596,6 +596,11 @@ function apply_callback!(integrator,
 
         @inbounds if callback.save_positions[2]
             savevalues!(integrator, true)
+            if callback isa VectorContinuousCallback
+                SciMLBase.save_discretes!(integrator, callback, event_idx)
+            else
+                SciMLBase.save_discretes!(integrator, callback)
+            end
             saved_in_cb = true
         end
         return true, saved_in_cb
@@ -622,6 +627,7 @@ end
         end
         @inbounds if callback.save_positions[2]
             savevalues!(integrator, true)
+            SciMLBase.save_discretes!(integrator, callback)
             saved_in_cb = true
         end
     end