Merge pull request #1142 from SciML/unitfulvalue

Properly extend unitfulvalue

Author: ChrisRackauckas

Project.toml

@@ -1,7 +1,7 @@
 name = "DiffEqBase"
 uuid = "2b5f629d-d688-5b77-993f-72d75c75574e"
 authors = ["Chris Rackauckas <[email protected]>"]
-version = "6.169.0"
+version = "6.169.1"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

ext/DiffEqBaseForwardDiffExt.jl

@@ -7,7 +7,7 @@ using DiffEqBase: Void, FunctionWrappersWrappers, OrdinaryDiffEqTag,
                   RecursiveArrayTools, reduce_tup, _promote_tspan, has_continuous_callback
 import DiffEqBase: hasdualpromote, wrapfun_oop, wrapfun_iip, prob2dtmin,
                    promote_tspan, anyeltypedual, isdualtype, value, ODE_DEFAULT_NORM,
-                   InternalITP, nextfloat_tdir, DualEltypeChecker, sse
+                   InternalITP, nextfloat_tdir, DualEltypeChecker, sse, unitfulvalue
 
 eltypedual(x) = eltype(x) <: ForwardDiff.Dual
 isdualtype(::Type{<:ForwardDiff.Dual}) = true
@@ -499,7 +499,7 @@ value(x::Type{ForwardDiff.Dual{T, V, N}}) where {T, V, N} = V
 value(x::ForwardDiff.Dual) = value(ForwardDiff.value(x))
 
 unitfulvalue(x::Type{ForwardDiff.Dual{T, V, N}}) where {T, V, N} = V
-unitfulvalue(x::ForwardDiff.Dual) = unitfulvalue(ForwardDiff.unitfulvalue(x))
+unitfulvalue(x::ForwardDiff.Dual) = unitfulvalue(ForwardDiff.value(x))
 
 sse(x::ForwardDiff.Dual) = sse(ForwardDiff.value(x)) + sum(sse, ForwardDiff.partials(x))
 function DiffEqBase.totallength(x::ForwardDiff.Dual)

test/downstream/unitful.jl

@@ -1,5 +1,9 @@
-using Unitful, OrdinaryDiffEq, Test
+using Unitful, OrdinaryDiffEq, ForwardDiff, Test
 f(du, u, p, t) = du .= 3 * u"1/s" * u
 prob = ODEProblem(f, [2.0u"m"], (0.0u"s", Inf * u"s"))
 intg = init(prob, Tsit5())
 @test_nowarn step!(intg, 0.02u"s", true)
+
+@test DiffEqBase.unitfulvalue(u"1/s") == u"1/s"
+@test DiffEqBase.value(ForwardDiff.Dual(1)*u"1/s") == 1
+@test DiffEqBase.unitfulvalue(ForwardDiff.Dual(1)*u"1/s") == u"1/s"