Merge pull request #1153 from SciML/static

Add static allocation checks and fix ComponentArrays allocs

Author: ChrisRackauckas

.github/workflows/Tests.yml

@@ -26,6 +26,7 @@ jobs:
           - Core
           - Downstream
           - Downstream2
+          - Static
     uses: "SciML/.github/.github/workflows/tests.yml@v1"
     with:
       julia-version: "${{ matrix.version }}"

src/common_defaults.jl

@@ -3,6 +3,11 @@ function abs2_and_sum(x, y)
     reduce(+, y, init = zero(real(value(eltype(y)))))
 end
 UNITLESS_ABS2(x::Number) = abs2(x)
+
+function UNITLESS_ABS2(x::AbstractArray{<:Number})
+    mapreduce(UNITLESS_ABS2, +, x, init = zero(real(value(eltype(x)))))
+end
+
 function UNITLESS_ABS2(x::AbstractArray)
     mapreduce(UNITLESS_ABS2, abs2_and_sum, x, init = zero(real(value(eltype(x)))))
 end

test/runtests.jl

@@ -11,6 +11,12 @@ function activate_downstream_env()
     Pkg.instantiate()
 end
 
+function activate_static_env()
+    Pkg.activate("static")
+    Pkg.develop(PackageSpec(path = dirname(@__DIR__)))
+    Pkg.instantiate()
+end
+
 function activate_gpu_env()
     Pkg.activate("gpu")
     Pkg.develop(PackageSpec(path = dirname(@__DIR__)))
@@ -55,6 +61,11 @@ end
         @time @safetestset "GTPSA Tests" include("downstream/gtpsa.jl")
     end
 
+    if !is_APPVEYOR && GROUP == "Static"
+        activate_static_env()
+        @time @safetestset "Static Checks" include("static/static_checks.jl")
+    end
+
     if !is_APPVEYOR && GROUP == "Downstream2"
         activate_downstream_env()
         @time @safetestset "Prob Kwargs" include("downstream/prob_kwargs.jl")

test/static/Project.toml

@@ -0,0 +1,5 @@
+[deps]
+AllocCheck = "9b6a8646-10ed-4001-bbdc-1d2f46dfbb1a"
+ComponentArrays = "b0b7db55-cfe3-40fc-9ded-d10e2dbeff66"
+
+[compat]

test/static/static_checks.jl

@@ -0,0 +1,5 @@
+using DiffEqBase, ComponentArrays, AllocCheck, Test
+
+u = ComponentArray(x=1.0, y=0.0, z=0.0)
+t = 0.0
+@test length(check_allocs(DiffEqBase.ODE_DEFAULT_NORM, (typeof(u), typeof(t)))) == 0