Skip to content

Move rest of promote_tspan to SciMLBase #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Move rest of promote_tspan to SciMLBase #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/DiffEqBaseForwardDiffExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ using DiffEqBase, ForwardDiff
using DiffEqBase.ArrayInterface
using DiffEqBase: Void, FunctionWrappersWrappers, OrdinaryDiffEqTag,
AbstractTimeseriesSolution,
RecursiveArrayTools, reduce_tup, _promote_tspan, has_continuous_callback
RecursiveArrayTools
import DiffEqBase: hasdualpromote, wrapfun_oop, wrapfun_iip, prob2dtmin,
promote_tspan, ODE_DEFAULT_NORM,
InternalITP, nextfloat_tdir
import SciMLBase: isdualtype, DualEltypeChecker, sse, __sum
import SciMLBase: isdualtype, DualEltypeChecker, sse, __sum, promote_tspan, has_continuous_callback

const dualT = ForwardDiff.Dual{ForwardDiff.Tag{OrdinaryDiffEqTag, Float64}, Float64, 1}
dualgen(::Type{T}) where {T} = ForwardDiff.Dual{ForwardDiff.Tag{OrdinaryDiffEqTag, T}, T, 1}
Expand Down
11 changes: 0 additions & 11 deletions src/solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,17 +828,6 @@ function get_concrete_problem(prob::DDEProblem, isadapt; kwargs...)
remake(prob; u0 = u0, tspan = tspan, p = p, constant_lags = constant_lags)
end

# Most are extensions
promote_tspan(u0, p, tspan, prob, kwargs) = _promote_tspan(tspan, kwargs)
function _promote_tspan(tspan, kwargs)
if (dt = get(kwargs, :dt, nothing)) !== nothing
tspan1, tspan2, _ = promote(tspan..., dt)
return (tspan1, tspan2)
else
return tspan
end
end

function promote_f(f::F, ::Val{specialize}, u0, p, t) where {F, specialize}
# Ensure our jacobian will be of the same type as u0
uElType = u0 === nothing ? Float64 : eltype(u0)
Expand Down
Loading