Skip to content

Fix Enzyme solve_up rule signature to support DuplicatedNoNeed #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2025
Merged

Fix Enzyme solve_up rule signature to support DuplicatedNoNeed #1218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ext/DiffEqBaseEnzymeExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ module DiffEqBaseEnzymeExt

function Enzyme.EnzymeRules.augmented_primal(
config::Enzyme.EnzymeRules.RevConfigWidth{1},
func::Const{typeof(DiffEqBase.solve_up)}, ::Type{Duplicated{RT}}, prob,
func::Const{typeof(DiffEqBase.solve_up)}, ::Type{RT}, prob,
sensealg::Union{
Const{Nothing}, Const{<:DiffEqBase.AbstractSensitivityAlgorithm}},
u0, p, args...; kwargs...) where {RT}
u0, p, args...; kwargs...) where {RT <: Union{Duplicated, DuplicatedNoNeed}}
@inline function copy_or_reuse(val, idx)
if Enzyme.EnzymeRules.overwritten(config)[idx] && ismutable(val)
return deepcopy(val)
Expand All @@ -31,18 +31,18 @@ module DiffEqBaseEnzymeExt
SciMLBase.EnzymeOriginator(), ntuple(arg_copy, Val(length(args)))...;
kwargs...)

dres = Enzyme.make_zero(res[1])::RT
ResType = typeof(res[1])
dres = Enzyme.make_zero(res[1])::ResType
tup = (dres, res[2])
return Enzyme.EnzymeRules.AugmentedReturn{RT, RT, Any}(res[1], dres, tup::Any)
return Enzyme.EnzymeRules.AugmentedReturn{ResType, ResType, Any}(res[1], dres, tup::Any)
end

function Enzyme.EnzymeRules.reverse(config::Enzyme.EnzymeRules.RevConfigWidth{1},
func::Const{typeof(DiffEqBase.solve_up)}, ::Type{Duplicated{RT}}, tape, prob,
func::Const{typeof(DiffEqBase.solve_up)}, ::Type{RT}, tape, prob,
sensealg::Union{
Const{Nothing}, Const{<:DiffEqBase.AbstractSensitivityAlgorithm}},
u0, p, args...; kwargs...) where {RT}
u0, p, args...; kwargs...) where {RT <: Union{Duplicated, DuplicatedNoNeed}}
dres, clos = tape
dres = dres::RT
dargs = clos(dres)
for (darg, ptr) in zip(dargs, (func, prob, sensealg, u0, p, args...))
if ptr isa Enzyme.Const
Expand Down
Loading