Skip to content

Commit c95ef24

Browse files
committed
Remove CartesianGridIter.
1 parent 276837b commit c95ef24

File tree

6 files changed

+9
-34
lines changed

6 files changed

+9
-34
lines changed

src/JumpProcesses.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export reset_aggregated_jumps!
9292
export ExtendedJumpArray
9393

9494
# spatial structs and functions
95-
export CartesianGrid, CartesianGridRej, CartesianGridIter
95+
export CartesianGrid, CartesianGridRej
9696
export SpatialMassActionJump
9797
export outdegree, num_sites, neighbors
9898
export NSM, DirectCRDirect

src/spatial/hop_rates.jl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,23 +14,23 @@ function HopRates(hopping_constants::Vector{F}, spatial_system) where {F <: Numb
1414
HopRatesGraphDs(hopping_constants, num_sites(spatial_system))
1515
end
1616
function HopRates(hopping_constants::Vector{F},
17-
grid::Union{CartesianGridRej, CartesianGridIter}) where {F <: Number}
17+
grid::CartesianGridRej) where {F <: Number}
1818
HopRatesGraphDs(hopping_constants, num_sites(grid))
1919
end
2020

2121
function HopRates(hopping_constants::Matrix{F}, spatial_system) where {F <: Number}
2222
HopRatesGraphDsi(hopping_constants)
2323
end
2424
function HopRates(hopping_constants::Matrix{F},
25-
grid::Union{CartesianGridRej, CartesianGridIter}) where {F <: Number}
25+
grid::CartesianGridRej) where {F <: Number}
2626
HopRatesGraphDsi(hopping_constants)
2727
end
2828

2929
function HopRates(hopping_constants::Matrix{Vector{F}}, spatial_system) where {F <: Number}
3030
HopRatesGraphDsij(hopping_constants)
3131
end
3232
function HopRates(hopping_constants::Matrix{Vector{F}},
33-
grid::Union{CartesianGridRej, CartesianGridIter}) where {F <: Number}
33+
grid::CartesianGridRej) where {F <: Number}
3434
HopRatesGridDsij(hopping_constants, grid)
3535
end
3636

@@ -40,7 +40,7 @@ function HopRates(p::Pair{SpecHop, SiteHop},
4040
HopRatesGraphDsLij(p...)
4141
end
4242
function HopRates(p::Pair{SpecHop, SiteHop},
43-
grid::Union{CartesianGridRej, CartesianGridIter}) where
43+
grid::CartesianGridRej) where
4444
{F <: Number, SpecHop <: Vector{F}, SiteHop <: Vector{Vector{F}}}
4545
HopRatesGridDsLij(p..., grid)
4646
end
@@ -51,7 +51,7 @@ function HopRates(p::Pair{SpecHop, SiteHop},
5151
HopRatesGraphDsiLij(p...)
5252
end
5353
function HopRates(p::Pair{SpecHop, SiteHop},
54-
grid::Union{CartesianGridRej, CartesianGridIter}) where
54+
grid::CartesianGridRej) where
5555
{SpecHop <: Matrix{F}, SiteHop <: Vector{Vector{F}}} where {F <: Number}
5656
HopRatesGridDsiLij(p..., grid)
5757
end

src/spatial/topology.jl

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -144,31 +144,7 @@ function rand_nbr(rng, grid::CartesianGridRej, site::Int)
144144
end
145145
end
146146

147-
# neighbor sampling is iterator-based
148-
struct CartesianGridIter{N, T}
149-
dims::NTuple{N, Int}
150-
nums_neighbors::Vector{Int}
151-
CI::CartesianIndices{N, T}
152-
LI::LinearIndices{N, T}
153-
offsets::Vector{CartesianIndex{N}}
154-
end
155-
function CartesianGridIter(dims::Tuple)
156-
dim = length(dims)
157-
CI = CartesianIndices(dims)
158-
LI = LinearIndices(dims)
159-
offsets = potential_offsets(dim)
160-
nums_neighbors = [count(x -> x + CI[site] in CI, offsets) for site in 1:prod(dims)]
161-
CartesianGridIter(dims, nums_neighbors, CI, LI, offsets)
162-
end
163-
CartesianGridIter(dims) = CartesianGridIter(Tuple(dims))
164-
function CartesianGridIter(dimension, linear_size::Int)
165-
CartesianGridIter([linear_size for i in 1:dimension])
166-
end
167-
function rand_nbr(rng, grid::CartesianGridIter, site::Int)
168-
nth_nbr(grid, site, rand(rng, 1:outdegree(grid, site)))
169-
end
170-
171147
function Base.show(io::IO, ::MIME"text/plain",
172-
grid::Union{CartesianGridRej, CartesianGridIter})
148+
grid::CartesianGridRej)
173149
println(io, "A Cartesian grid with dimensions $(grid.dims)")
174150
end

test/spatial/ABC.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ function get_mean_end_state(jump_prob, Nsims)
4646
end
4747

4848
# testing
49-
grids = [CartesianGridRej(dims), CartesianGridIter(dims), Graphs.grid(dims)]
49+
grids = [CartesianGridRej(dims), Graphs.grid(dims)]
5050
jump_problems = JumpProblem[JumpProblem(prob, NSM(), majumps,
5151
hopping_constants = hopping_constants,
5252
spatial_system = grid,

test/spatial/diffusion.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ rel_tol = 0.01
6060
times = 0.0:(tf / num_time_points):tf
6161

6262
algs = [NSM(), DirectCRDirect()]
63-
grids = [CartesianGridRej(dims), CartesianGridIter(dims), Graphs.grid(dims)]
63+
grids = [CartesianGridRej(dims), Graphs.grid(dims)]
6464
jump_problems = JumpProblem[JumpProblem(prob, algs[2], majumps,
6565
hopping_constants = hopping_constants,
6666
spatial_system = grid,

test/spatial/topology.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ num_samples = 10^5
1717
rel_tol = 0.01
1818
grids = [
1919
JP.CartesianGridRej(dims),
20-
JP.CartesianGridIter(dims),
2120
Graphs.grid(dims),
2221
]
2322
for grid in grids

0 commit comments

Comments
 (0)