comments

Author: vpuri3

src/factorization.jl

@@ -381,6 +381,8 @@ struct DiagonalFactorization <: AbstractFactorization end
 
 function init_cacheval(alg::DiagonalFactorization, A, b, u, Pl, Pr, maxiters::Int,
                        abstol, reltol, verbose::Bool, assumptions::OperatorAssumptions)
+    # TODO - DiagonalFactorization should preinvert, and mul!
+    #Diagonal(inv.(A.diag))
     nothing
 end
 

src/iterative_wrappers.jl

@@ -151,6 +151,7 @@ function SciMLBase.solve(cache::LinearCache, alg::KrylovJL; kwargs...)
     N = cache.Pr
 
     # use no-op preconditioner for Krylov.jl (LinearAlgebra.I) when M/N is identity
+    # TODO - https://github.com/JuliaSmoothOptimizers/Krylov.jl/issues/612#issuecomment-1227391841
     M = _isidentity_struct(M) ? I : InvertedOperator(M)
     N = _isidentity_struct(M) ? I : InvertedOperator(N)