Skip to content

Commit 16557b9

Browse files
workaround Cholesky factorization limitations on v1.6
It won't handle adjoint but that makes it error even when its not used from the default choice, and so this makes it so the defaults don't error. Past v1.7 it's not needed.
1 parent 3f54753 commit 16557b9

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

src/factorization.jl

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -260,13 +260,7 @@ function init_cacheval(alg::CholeskyFactorization, A::Matrix{Float64}, b, u, Pl,
260260
PREALLOCATED_CHOLESKY
261261
end
262262

263-
function init_cacheval(alg::CholeskyFactorization, A::Diagonal, b, u, Pl, Pr,
264-
maxiters::Int, abstol, reltol, verbose::Bool,
265-
assumptions::OperatorAssumptions)
266-
nothing
267-
end
268-
269-
function init_cacheval(alg::CholeskyFactorization, A::AbstractSciMLOperator, b, u, Pl, Pr,
263+
function init_cacheval(alg::CholeskyFactorization, A::Union{Diagonal,AbstractSciMLOperator}, b, u, Pl, Pr,
270264
maxiters::Int, abstol, reltol, verbose::Bool,
271265
assumptions::OperatorAssumptions)
272266
nothing
@@ -281,7 +275,7 @@ end
281275
end
282276

283277
function init_cacheval(alg::CholeskyFactorization,
284-
A::Adjoint{<:Array}, b, u, Pl, Pr,
278+
A::Adjoint{<:Number, <:Array}, b, u, Pl, Pr,
285279
maxiters::Int, abstol, reltol, verbose::Bool,
286280
assumptions::OperatorAssumptions)
287281
nothing

0 commit comments

Comments
 (0)