Skip to content

Commit 1748f9b

Browse files
Fix method override in CUDA (#748)
* Fix method override in CUDA * Update LinearSolveCUSOLVERRFExt.jl * Update LinearSolveCliqueTreesExt.jl * Update LinearSolveBLISExt.jl
1 parent 6a3dfaf commit 1748f9b

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

ext/LinearSolveBLISExt.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ using LinearSolve
99
using LinearAlgebra: BlasInt, LU
1010
using LinearAlgebra.LAPACK: require_one_based_indexing, chkfinite, chkstride1,
1111
@blasfunc, chkargsok
12-
using LinearSolve: ArrayInterface, BLISLUFactorization, @get_cacheval, LinearCache, SciMLBase
12+
using LinearSolve: ArrayInterface, BLISLUFactorization, @get_cacheval, LinearCache, SciMLBase, LinearVerbosity
1313
using SciMLBase: ReturnCode
1414

1515
const global libblis = blis_jll.blis

ext/LinearSolveCUDAExt.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function SciMLBase.solve!(cache::LinearSolve.LinearCache, alg::CudaOffloadLUFact
5353
SciMLBase.build_linear_solution(alg, y, nothing, cache)
5454
end
5555

56-
function LinearSolve.init_cacheval(alg::CudaOffloadLUFactorization, A, b, u, Pl, Pr,
56+
function LinearSolve.init_cacheval(alg::CudaOffloadLUFactorization, A::AbstractArray, b, u, Pl, Pr,
5757
maxiters::Int, abstol, reltol, verbose::LinearVerbosity,
5858
assumptions::OperatorAssumptions)
5959
T = eltype(A)
@@ -95,7 +95,7 @@ function SciMLBase.solve!(cache::LinearSolve.LinearCache, alg::CudaOffloadFactor
9595
SciMLBase.build_linear_solution(alg, y, nothing, cache)
9696
end
9797

98-
function LinearSolve.init_cacheval(alg::CudaOffloadFactorization, A, b, u, Pl, Pr,
98+
function LinearSolve.init_cacheval(alg::CudaOffloadFactorization, A::AbstractArray, b, u, Pl, Pr,
9999
maxiters::Int, abstol, reltol, verbose::LinearVerbosity,
100100
assumptions::OperatorAssumptions)
101101
qr(CUDA.CuArray(A))

ext/LinearSolveCUSOLVERRFExt.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module LinearSolveCUSOLVERRFExt
22

3-
using LinearSolve: LinearSolve, @get_cacheval, pattern_changed, OperatorAssumptions
3+
using LinearSolve: LinearSolve, @get_cacheval, pattern_changed, OperatorAssumptions, LinearVerbosity
44
using CUSOLVERRF: CUSOLVERRF, RFLU, CUDA
55
using SparseArrays: SparseArrays, SparseMatrixCSC, nnz
66
using CUSOLVERRF.CUDA.CUSPARSE: CuSparseMatrixCSR
@@ -86,4 +86,4 @@ function LinearSolve.pattern_changed(rf::RFLU, A::CuSparseMatrixCSR)
8686
end
8787

8888

89-
end
89+
end

ext/LinearSolveCliqueTreesExt.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ module LinearSolveCliqueTreesExt
22

33
using CliqueTrees: symbolic, cholinit, lininit, cholesky!, linsolve!
44
using LinearSolve
5+
using LinearSolve: LinearVerbosity
56
using SparseArrays
67

78
function _symbolic(A::AbstractMatrix, alg::CliqueTreesFactorization)

0 commit comments

Comments
 (0)