Merge pull request #448 from SciML/ap/patch_satest

Patch the Static Arrays tests

Author: ChrisRackauckas

Project.toml

@@ -101,6 +101,7 @@ SciMLOperators = "0.3"
 Setfield = "1"
 SparseArrays = "1.9"
 Sparspak = "0.3.6"
+StableRNGs = "1"
 StaticArrays = "1.5"
 StaticArraysCore = "1.2"
 Test = "1"
@@ -129,8 +130,9 @@ Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
 SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
+StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
 StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["Aqua", "Test", "IterativeSolvers", "InteractiveUtils", "JET", "KrylovKit", "Pkg", "Random", "SafeTestsets", "MultiFloats", "ForwardDiff", "HYPRE", "MPI", "BlockDiagonals", "Enzyme", "FiniteDiff", "BandedMatrices", "FastAlmostBandedMatrices", "StaticArrays", "AllocCheck"]
+test = ["Aqua", "Test", "IterativeSolvers", "InteractiveUtils", "JET", "KrylovKit", "Pkg", "Random", "SafeTestsets", "MultiFloats", "ForwardDiff", "HYPRE", "MPI", "BlockDiagonals", "Enzyme", "FiniteDiff", "BandedMatrices", "FastAlmostBandedMatrices", "StaticArrays", "AllocCheck", "StableRNGs"]

src/factorization_sparse.jl

@@ -13,3 +13,10 @@ function _ldiv!(x::AbstractVector,
         SparseArrays.CHOLMOD.Factor}, b::AbstractVector)
     x .= A \ b
 end
+
+# Ambiguity removal
+_ldiv!(::SVector, 
+       A::Union{SparseArrays.CHOLMOD.Factor, LinearAlgebra.QR, LinearAlgebra.QRCompactWY, SparseArrays.SPQR.QRSparse}, 
+       b::AbstractVector) = (A \ b)
+_ldiv!(::SVector, A::Union{SparseArrays.CHOLMOD.Factor, LinearAlgebra.QR, LinearAlgebra.QRCompactWY, SparseArrays.SPQR.QRSparse}, 
+       b::SVector) = (A \ b)

test/static_arrays.jl

@@ -1,8 +1,10 @@
-using LinearSolve, StaticArrays, LinearAlgebra, Test
+using LinearSolve, StaticArrays, LinearAlgebra, Test, StableRNGs
 using AllocCheck
 
-A = SMatrix{5, 5}(Hermitian(rand(5, 5) + I))
-b = SVector{5}(rand(5))
+rng = StableRNG(0)
+
+A = SMatrix{5, 5}(Hermitian(rand(rng, 5, 5) + I))
+b = SVector{5}(rand(rng, 5))
 
 @check_allocs __solve_no_alloc(A, b, alg) = solve(LinearProblem(A, b), alg)
 
@@ -27,16 +29,16 @@ for alg in (nothing, LUFactorization(), SVDFactorization(), CholeskyFactorizatio
     @test norm(A * sol .- b) < 1e-10
 end
 
-A = SMatrix{7, 5}(rand(7, 5))
-b = SVector{7}(rand(7))
+A = SMatrix{7, 5}(rand(rng, 7, 5))
+b = SVector{7}(rand(rng, 7))
 
 for alg in (nothing, SVDFactorization(), KrylovJL_LSMR())
     @inferred solve(LinearProblem(A, b), alg)
     @test_nowarn solve(LinearProblem(A, b), alg)
 end
 
-A = SMatrix{5, 7}(rand(5, 7))
-b = SVector{5}(rand(5))
+A = SMatrix{5, 7}(rand(rng, 5, 7))
+b = SVector{5}(rand(rng, 5))
 
 for alg in (nothing, SVDFactorization(), KrylovJL_LSMR())
     @inferred solve(LinearProblem(A, b), alg)