bring in linalg, add tols to tests

Author: jClugstor

ext/LinearSolveForwardDiffExt.jl

@@ -1,6 +1,7 @@
 module LinearSolveForwardDiffExt
 
 using LinearSolve
+using LinearAlgebra
 using ForwardDiff
 using ForwardDiff: Dual, Partials
 using SciMLBase
@@ -53,6 +54,8 @@ function linearsolve_forwarddiff_solve(cache::DualLinearCache, alg, args...; kwa
     partial_prob = LinearProblem(cache.cache.A, rhs_list[1])
     partial_cache = init(partial_prob, alg, args...; kwargs...)
 
+    Main.@infiltrate
+
     for i in eachindex(rhs_list)
         partial_cache.b = rhs_list[i]
         rhs_list[i] = copy(solve!(partial_cache, alg).u)
@@ -107,7 +110,6 @@ function xp_linsolve_rhs(uu, ∂_A::Union{<:Partials, <:AbstractArray{<:Partials
     b_list = partials_to_list(∂_b)
 
     Auu = [A * uu for A in A_list]
-
     b_list .- Auu
 end
 
@@ -117,13 +119,13 @@ function xp_linsolve_rhs(
 
     Auu = [A * uu for A in A_list]
 
-    Auu
+    -Auu
 end
 
 function xp_linsolve_rhs(
         uu, ∂_A::Nothing, ∂_b::Union{<:Partials, <:AbstractArray{<:Partials}})
     b_list = partials_to_list(∂_b)
-
+    Main.@infiltrate
     b_list
 end
 

test/forwarddiff_overloads.jl

@@ -13,15 +13,15 @@ A, b = h([ForwardDiff.Dual(5.0, 1.0, 0.0), ForwardDiff.Dual(5.0, 0.0, 1.0)])
 
 prob = LinearProblem(A, b)
 overload_x_p = solve(prob)
-original_x_p = solve!(init(prob))
+original_x_p = A \ b
 
-@test overload_x_p ≈ original_x_p
+@test ≈(overload_x_p, original_x_p, rtol = 1e-9)
 
 A, _ = h([ForwardDiff.Dual(5.0, 1.0, 0.0), ForwardDiff.Dual(5.0, 0.0, 1.0)])
 prob = LinearProblem(A, [6.0, 10.0, 25.0])
-@test solve(prob).retcode == ReturnCode.Default
+@test ≈(solve(prob).u, A \ [6.0, 10.0, 25.0], rtol = 1e-9) 
 
 _, b = h([ForwardDiff.Dual(5.0, 1.0, 0.0), ForwardDiff.Dual(5.0, 0.0, 1.0)])
 A = [5.0 6.0 125.0; 15.0 10.0 21.0; 25.0 45.0 5.0]
 prob = LinearProblem(A, b)
-@test solve(prob).retcode == ReturnCode.Default
+@test ≈(solve(prob).u, A \ b, rtol = 1e-9)