Skip to content

Commit 290c82f

Browse files
Fix QR initializations with pivoting
Fixes #335
1 parent 19cfb42 commit 290c82f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ SuiteSparse = "4607b0f0-06f3-5cda-b6b1-a6196a1729e9"
2727
UnPack = "3a884ed6-31ef-47d7-9d2a-63182c4928ed"
2828

2929
[compat]
30-
ArrayInterface = "7.4.7"
30+
ArrayInterface = "7.4.11"
3131
DocStringExtensions = "0.8, 0.9"
3232
EnumX = "1"
3333
FastLapackInterface = "1"

src/factorization.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,12 @@ end
171171
function init_cacheval(alg::QRFactorization, A, b, u, Pl, Pr,
172172
maxiters::Int, abstol, reltol, verbose::Bool,
173173
assumptions::OperatorAssumptions)
174-
ArrayInterface.qr_instance(convert(AbstractMatrix, A))
174+
ArrayInterface.qr_instance(convert(AbstractMatrix, A), alg.pivot)
175175
end
176176

177177
const PREALLOCATED_QR = ArrayInterface.qr_instance(rand(1, 1))
178178

179-
function init_cacheval(alg::QRFactorization, A::Matrix{Float64}, b, u, Pl, Pr,
179+
function init_cacheval(alg::QRFactorization{NoPivot}, A::Matrix{Float64}, b, u, Pl, Pr,
180180
maxiters::Int, abstol, reltol, verbose::Bool,
181181
assumptions::OperatorAssumptions)
182182
PREALLOCATED_QR

0 commit comments

Comments
 (0)