Skip to content

Commit 3851731

Browse files
ChrisRackauckas-ClaudeChrisRackauckasclaude
authored
Add warning messages when algorithms are skipped in autotune benchmarking (#723)
* Add warning messages when algorithms are skipped in autotune benchmarking When algorithms exceed maxtime during benchmarking, they are correctly skipped for larger matrix sizes. However, users only saw the initial "exceeded maxtime" warning but not when algorithms were subsequently skipped, making it unclear why some algorithms weren't being tested on larger matrices. This adds explicit warning messages when algorithms are skipped, providing better visibility into the autotuning process. Fixes the issue where users would see: - "Algorithm X exceeded maxtime" warnings - But no indication that Algorithm X was being skipped for larger sizes Now users will see both: - "Algorithm X exceeded maxtime (Y.Zs > maxtime) for size N" - "Algorithm X skipped for size M (exceeded maxtime on size N matrix)" 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Improve readability of skip warning messages Add a newline before skip warnings to ensure they appear cleanly separated from progress bar output, making them much easier to read. Before: Skip warnings were mixed inline with progress bar After: Skip warnings appear on clean new lines 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: ChrisRackauckas <[email protected]> Co-authored-by: Claude <[email protected]>
1 parent 149f0b3 commit 3851731

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

lib/LinearSolveAutotune/src/benchmarking.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,9 @@ function benchmark_algorithms(matrix_sizes, algorithms, alg_names, eltypes;
148148
if haskey(blocked_algorithms[string(eltype)], name)
149149
max_allowed_size = blocked_algorithms[string(eltype)][name]
150150
if n > max_allowed_size
151+
# Clear progress line and show warning on new line
152+
println() # Ensure we're on a new line
153+
@warn "Algorithm $name skipped for size $n (exceeded maxtime on size $max_allowed_size matrix)"
151154
# Still need to update progress bar
152155
ProgressMeter.next!(progress)
153156
# Record as skipped due to exceeding maxtime on smaller matrix

0 commit comments

Comments
 (0)