Merge pull request #327 from SciML/umfpack

Fix and better test UMFPACK default

Author: ChrisRackauckas

src/factorization.jl

@@ -84,7 +84,8 @@ end
 function do_factorization(alg::LUFactorization, A, b, u)
     A = convert(AbstractMatrix, A)
     if A isa AbstractSparseMatrixCSC
-        return lu(SparseMatrixCSC(size(A)..., getcolptr(A), rowvals(A), nonzeros(A)), check=false)
+        return lu(SparseMatrixCSC(size(A)..., getcolptr(A), rowvals(A), nonzeros(A)),
+            check = false)
     else
         fact = lu!(A, alg.pivot, check = false)
     end
@@ -707,16 +708,17 @@ function SciMLBase.solve!(cache::LinearCache, alg::UMFPACKFactorization; kwargs.
     A = cache.A
     A = convert(AbstractMatrix, A)
     if cache.isfresh
+        cacheval = @get_cacheval(cache, :UMFPACKFactorization)
         if alg.reuse_symbolic
             # Caches the symbolic factorization: https://github.com/JuliaLang/julia/pull/33738
             if alg.check_pattern && !(SuiteSparse.decrement(SparseArrays.getcolptr(A)) ==
-                 cache.cacheval.colptr &&
+                 cacheval.colptr &&
                  SuiteSparse.decrement(SparseArrays.getrowval(A)) ==
-                 @get_cacheval(cache, :UMFPACKFactorization).rowval)
+                 cacheval.rowval)
                 fact = lu(SparseMatrixCSC(size(A)..., getcolptr(A), rowvals(A),
                     nonzeros(A)))
             else
-                fact = lu!(@get_cacheval(cache, :UMFPACKFactorization),
+                fact = lu!(cacheval,
                     SparseMatrixCSC(size(A)..., getcolptr(A), rowvals(A),
                         nonzeros(A)))
             end

test/default_algs.jl

@@ -1,21 +1,35 @@
 using LinearSolve, LinearAlgebra, SparseArrays, Test, JET
 @test LinearSolve.defaultalg(nothing, zeros(3)).alg ===
       LinearSolve.DefaultAlgorithmChoice.GenericLUFactorization
+prob = LinearProblem(rand(3, 3), rand(3))
+solve(prob)
+
 @test LinearSolve.defaultalg(nothing, zeros(50)).alg ===
       LinearSolve.DefaultAlgorithmChoice.RFLUFactorization
+prob = LinearProblem(rand(50, 50), rand(50))
+solve(prob)
+
 @test LinearSolve.defaultalg(nothing, zeros(600)).alg ===
       LinearSolve.DefaultAlgorithmChoice.GenericLUFactorization
+prob = LinearProblem(rand(600, 600), rand(600))
+solve(prob)
+
 @test LinearSolve.defaultalg(LinearAlgebra.Diagonal(zeros(5)), zeros(5)).alg ===
       LinearSolve.DefaultAlgorithmChoice.DiagonalFactorization
 
 @test LinearSolve.defaultalg(nothing, zeros(5),
     LinearSolve.OperatorAssumptions(false)).alg ===
       LinearSolve.DefaultAlgorithmChoice.QRFactorization
 
-@test LinearSolve.defaultalg(sprand(1000, 1000, 0.01), zeros(1000)).alg ===
+@test LinearSolve.defaultalg(sprand(1000, 1000, 0.5), zeros(1000)).alg ===
       LinearSolve.DefaultAlgorithmChoice.KLUFactorization
+prob = LinearProblem(sprand(1000, 1000, 0.5), zeros(1000))
+solve(prob)
+
 @test LinearSolve.defaultalg(sprand(11000, 11000, 0.001), zeros(11000)).alg ===
       LinearSolve.DefaultAlgorithmChoice.UMFPACKFactorization
+prob = LinearProblem(sprand(11000, 11000, 0.5), zeros(11000))
+solve(prob)
 
 @static if VERSION >= v"v1.7-"
     # Test inference