Skip to content

Commit 4331d74

Browse files
committed
Fix CUDA extension issues
- Remove stub init_cacheval for CudaOffloadLUFactorization from base package to avoid method overwriting error during precompilation - Move CUDA from deps to weakdeps since it's only needed for the extension These changes fix: 1. Method overwriting error during module precompilation 2. Aqua.jl stale deps test failure for CUDA 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 11ed2be commit 4331d74

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ version = "3.33.0"
55

66
[deps]
77
ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
8-
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
98
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
109
ConcreteStructs = "2569d6c7-a4a2-43d3-a901-331e8e4be471"
1110
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
@@ -33,6 +32,7 @@ UnPack = "3a884ed6-31ef-47d7-9d2a-63182c4928ed"
3332
AMDGPU = "21141c5a-9bdb-4563-92ae-f87d6854732e"
3433
BandedMatrices = "aae01518-5342-5314-be14-df237901396f"
3534
BlockDiagonals = "0a1fb500-61f7-11e9-3c65-f5ef3456f9f0"
35+
CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba"
3636
CUDSS = "45b445bb-4962-46a0-9369-b4df9d0f772e"
3737
CUSOLVERRF = "a8cc9031-bad2-4722-94f5-40deabb4245c"
3838
CliqueTrees = "60701a23-6482-424a-84db-faee86b9b1f8"

src/factorization.jl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1210,10 +1210,6 @@ function init_cacheval(::BLISLUFactorization, A, b, u, Pl, Pr,
12101210
nothing
12111211
end
12121212

1213-
function init_cacheval(::CudaOffloadLUFactorization, A, b, u, Pl, Pr,
1214-
maxiters::Int, abstol, reltol, verbose::LinearVerbosity, assumptions::OperatorAssumptions)
1215-
nothing
1216-
end
12171213

12181214
function init_cacheval(::MetalLUFactorization, A, b, u, Pl, Pr,
12191215
maxiters::Int, abstol, reltol, verbose::LinearVerbosity, assumptions::OperatorAssumptions)

0 commit comments

Comments
 (0)