Skip to content

Commit 4b7ef0a

Browse files
committed
Integrate OpenBLASLUFactorization into existing test suite
- Add OpenBLASLUFactorization to basictests.jl alongside other factorizations - Include in resolve.jl subtype iteration tests - Add to preferences.jl algorithm availability tests - Remove separate test file in favor of integrated testing
1 parent 5a97dbb commit 4b7ef0a

File tree

4 files changed

+11
-60
lines changed

4 files changed

+11
-60
lines changed

test/basictests.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,9 @@ end
287287
push!(test_algs, MKLLUFactorization())
288288
end
289289

290+
# Always test OpenBLAS since it's a direct dependency
291+
push!(test_algs, OpenBLASLUFactorization())
292+
290293
# Test BLIS if extension is available
291294
if Base.get_extension(LinearSolve, :LinearSolveBLISExt) !== nothing
292295
push!(test_algs, BLISLUFactorization())

test/preferences.jl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,12 @@ using Preferences
190190
println("✅ MKLLUFactorization confirmed working")
191191
end
192192

193+
# Test OpenBLAS (always available as a dependency)
194+
sol_openblas = solve(prob, OpenBLASLUFactorization())
195+
@test sol_openblas.retcode == ReturnCode.Success
196+
@test norm(A * sol_openblas.u - b) < 1e-8
197+
println("✅ OpenBLASLUFactorization confirmed working")
198+
193199
# Test Apple Accelerate if available
194200
if LinearSolve.appleaccelerate_isavailable()
195201
sol_apple = solve(prob, AppleAccelerateLUFactorization())

test/resolve.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ for alg in vcat(InteractiveUtils.subtypes(AbstractDenseFactorization),
1919
]) &&
2020
(!(alg == AppleAccelerateLUFactorization) ||
2121
LinearSolve.appleaccelerate_isavailable()) &&
22-
(!(alg == MKLLUFactorization) || LinearSolve.usemkl)
22+
(!(alg == MKLLUFactorization) || LinearSolve.usemkl) &&
23+
(!(alg == OpenBLASLUFactorization) || true) # OpenBLAS is always available as a dependency
2324
A = [1.0 2.0; 3.0 4.0]
2425
alg in [KLUFactorization, UMFPACKFactorization, SparspakFactorization] &&
2526
(A = sparse(A))

test_openblas.jl

Lines changed: 0 additions & 59 deletions
This file was deleted.

0 commit comments

Comments
 (0)