kwargs kinda working. still need to standardize across wrappers

Author: vpuri3

src/wrappers.jl

@@ -138,14 +138,14 @@ function SciMLBase.solve(cache::LinearCache, alg::KrylovJL; kwargs...)
     args   = (cache.cacheval, cache.A, cache.b)
     kwargs = (atol=abstol, rtol=reltol, itmax=maxiter, alg.kwargs...)
 
-    if cache.cacheval == Krylov.CgSolver
+    if cache.cacheval == Krylov.GmresSolver
+        Krylov.solve!(args...; M=alg.Pl, N=alg.Pr,
+                      kwargs...)
+    elseif cache.cacheval == Krylov.CgSolver
         alg.Pr != LinearAlgebra.I  &&
             @warn "$(alg.KrylovAlg) doesn't support right preconditioning."
         Krylov.solve!(args...; M=alg.Pl,
                       kwargs...)
-    elseif cache.cacheval == Krylov.GmresSolver
-        Krylov.solve!(args...; M=alg.Pl, N=alg.Pr,
-                      kwargs...)
     else
         Krylov.solve!(args...; M=alg.Pl, N=alg.Pr,
                       kwargs...)

test/runtests.jl

@@ -3,7 +3,7 @@ using Test
 
 @testset "LinearSolve.jl" begin
     using LinearAlgebra
-    n = 32
+    n = 8
 
     A = Matrix(I,n,n)
     b = ones(n)
@@ -21,25 +21,26 @@ using Test
         A3 = prob3.A; b3 = prob3.b; x3 = prob3.u0
 
         @eval begin
-            y = solve($prob1, $alg($kwargs...))
+            y = solve($prob1, $alg(;$kwargs...))
             @test $A1 *  y  ≈ $b1 # out of place
             @test $A1 * $x1 ≈ $b1 # in place
 
-            y = $alg($kwargs...)($x2, $A2, $b2)    # alg is callable
+            y = $alg(;$kwargs...)($x2, $A2, $b2)      # alg is callable
             @test $A2 *  y  ≈ $b2
             @test $A2 * $x2 ≈ $b2
 
-            cache = SciMLBase.init($prob1, $alg($kwargs...)) # initialize cache
-            y = cache($x3, $A1, $b1)               # cache is callable
+            cache = SciMLBase.init($prob1,            # initialize cache
+                                   $alg(;$kwargs...)) 
+            y = cache($x3, $A1, $b1)                  # cache is callable
             @test $A1 *  y  ≈ $b1
             @test $A1 * $x3 ≈ $b1
 
-            y = cache($x3, $A1, $b2)               # reuse factorization
+            y = cache($x3, $A1, $b2)                  # reuse factorization
             @test $A1 *  y  ≈ $b2
             @test $A1 * $x3 ≈ $b2
 
-            y = cache($x3, $A2, $b3)               # new factorization
-            @test $A2 *  y  ≈ $b3                  # same old cache
+            y = cache($x3, $A2, $b3)                  # new factorization
+            @test $A2 *  y  ≈ $b3                     # same old cache
             @test $A2 * $x3 ≈ $b3
         end
 
@@ -57,7 +58,7 @@ using Test
     end
 
     # KrylovJL
-    kwargs = :(verbose=1, abstol=1e-1, reltol=1e-1, maxiters=3, restart=5)
+    kwargs = :(verbose=1, abstol=1e-1, reltol=1e-1, maxiter=3, restart=5)
     for alg in (
                 :KrylovJL,
                 :KrylovJL_CG,
@@ -69,7 +70,7 @@ using Test
     end
 
     # IterativeSolversJL
-    kwargs = :(abstol=1e-1, reltol=1e-1, maxiters=3, restart=5)
+    kwargs = :(abstol=1e-1, reltol=1e-1, maxiter=3, restart=5)
     for alg in (
                 :IterativeSolversJL,
                 :IterativeSolversJL_CG,