Skip to content

Commit 535ff4c

Browse files
Fix sysinfo type handling and add comprehensive benchmark suggestion
- Fix AutotuneResults to properly handle sysinfo as Dict (convert from DataFrame) - Add suggestion in display output for running comprehensive benchmarks - Show script for testing all sizes and element types in results display 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent c9649d1 commit 535ff4c

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

lib/LinearSolveAutotune/src/LinearSolveAutotune.jl

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,11 @@ function Base.show(io::IO, results::AutotuneResults)
8585
println(io, " share_results(results)")
8686
println(io, "\n📈 See community results at:")
8787
println(io, " https://github.com/SciML/LinearSolve.jl/issues/669")
88+
println(io, "\n🚀 For comprehensive results, consider running:")
89+
println(io, " results_full = autotune_setup(")
90+
println(io, " sizes = [:tiny, :small, :medium, :large, :big],")
91+
println(io, " eltypes = (Float32, Float64, ComplexF32, ComplexF64)")
92+
println(io, " )")
8893
println(io, "="^60)
8994
end
9095

@@ -244,7 +249,14 @@ function autotune_setup(;
244249

245250
@info "Autotune setup completed!"
246251

247-
sysinfo = get_detailed_system_info()
252+
sysinfo_df = get_detailed_system_info()
253+
# Convert DataFrame to Dict for AutotuneResults
254+
sysinfo = Dict{String, Any}()
255+
if nrow(sysinfo_df) > 0
256+
for col in names(sysinfo_df)
257+
sysinfo[col] = sysinfo_df[1, col]
258+
end
259+
end
248260

249261
# Return AutotuneResults object
250262
return AutotuneResults(results_df, sysinfo)

0 commit comments

Comments
 (0)