Commit 5a3f480
Fix preference tests: only print on failure, correct extension-dependent status
This commit addresses the specific feedback about the preference tests:
1. FastLUFactorization testing: Only print warnings when loading fails,
not on success (since successful loading is expected behavior)
2. RFLUFactorization testing: Only print warnings when loading fails,
not on success (since it's extension-dependent)
3. Clarified that RFLUFactorization is extension-dependent, not always available
(requires RecursiveFactorization.jl extension)
## Changes Made
### **Silent Success, Verbose Failure**
- FastLUFactorization: No print on successful loading/testing
- RFLUFactorization: No print on successful loading/testing
- Only print warnings when extensions fail to load or algorithms fail to work
### **Correct Extension Status**
- Updated comments to clarify RFLUFactorization requires RecursiveFactorization.jl extension
- Removed implication that RFLUFactorization is always available
- Proper categorization: always-loaded vs extension-dependent algorithms
### **Clean Test Output**
- Reduces noise in test output when extensions work correctly
- Highlights only actual issues with extension loading
- Maintains clear feedback about algorithm selection behavior
The test now properly validates the preference system behavior with clean
output that only reports issues, not expected successful behavior.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>1 parent 5eda050 commit 5a3f480
1 file changed
+13
-19
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
82 | 78 | | |
83 | 79 | | |
84 | | - | |
| 80 | + | |
85 | 81 | | |
86 | 82 | | |
87 | 83 | | |
| |||
104 | 100 | | |
105 | 101 | | |
106 | 102 | | |
107 | | - | |
| 103 | + | |
108 | 104 | | |
109 | 105 | | |
110 | 106 | | |
111 | | - | |
| 107 | + | |
112 | 108 | | |
113 | 109 | | |
114 | 110 | | |
115 | 111 | | |
116 | | - | |
117 | | - | |
118 | | - | |
| 112 | + | |
119 | 113 | | |
120 | 114 | | |
121 | 115 | | |
122 | | - | |
| 116 | + | |
123 | 117 | | |
124 | 118 | | |
125 | 119 | | |
| |||
165 | 159 | | |
166 | 160 | | |
167 | 161 | | |
168 | | - | |
| 162 | + | |
169 | 163 | | |
170 | 164 | | |
171 | 165 | | |
172 | 166 | | |
173 | 167 | | |
174 | | - | |
| 168 | + | |
175 | 169 | | |
176 | 170 | | |
177 | 171 | | |
| |||
0 commit comments