Skip to content

Commit 6b03761

Browse files
Fix telemetry system info key compatibility
- Use get() with fallbacks for all system info fields - Handle both get_system_info() and get_detailed_system_info() key names - Support both old and new key formats for compatibility
1 parent 5c9ada2 commit 6b03761

File tree

1 file changed

+19
-11
lines changed

1 file changed

+19
-11
lines changed

lib/LinearSolveAutotune/src/telemetry.jl

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -99,17 +99,25 @@ Format system information as markdown.
9999
"""
100100
function format_system_info_markdown(system_info::Dict)
101101
lines = String[]
102-
push!(lines, "- **Julia Version**: $(system_info["julia_version"])")
103-
push!(lines, "- **OS**: $(system_info["os"])")
104-
push!(lines, "- **Architecture**: $(system_info["arch"])")
105-
push!(lines, "- **CPU**: $(system_info["cpu_name"])")
106-
push!(lines, "- **Cores**: $(system_info["num_cores"])")
107-
push!(lines, "- **Threads**: $(system_info["num_threads"])")
108-
push!(lines, "- **BLAS**: $(system_info["blas_vendor"])")
109-
push!(lines, "- **MKL Available**: $(system_info["mkl_available"])")
110-
push!(lines, "- **Apple Accelerate Available**: $(system_info["apple_accelerate_available"])")
111-
push!(lines, "- **CUDA Available**: $(system_info["has_cuda"])")
112-
push!(lines, "- **Metal Available**: $(system_info["has_metal"])")
102+
push!(lines, "- **Julia Version**: $(get(system_info, "julia_version", "unknown"))")
103+
# Handle both "os" and "os_version" keys, with os_name for display
104+
os_display = get(system_info, "os_name", "unknown")
105+
os_kernel = get(system_info, "os_version", get(system_info, "os", "unknown"))
106+
push!(lines, "- **OS**: $os_display ($os_kernel)")
107+
# Handle both "arch" and "architecture" keys
108+
push!(lines, "- **Architecture**: $(get(system_info, "architecture", get(system_info, "arch", "unknown")))")
109+
push!(lines, "- **CPU**: $(get(system_info, "cpu_name", "unknown"))")
110+
# Handle both "num_cores" and "cpu_cores" keys
111+
push!(lines, "- **Cores**: $(get(system_info, "cpu_cores", get(system_info, "num_cores", "unknown")))")
112+
# Handle both "num_threads" and "julia_threads" keys
113+
push!(lines, "- **Threads**: $(get(system_info, "julia_threads", get(system_info, "num_threads", "unknown")))")
114+
push!(lines, "- **BLAS**: $(get(system_info, "blas_vendor", "unknown"))")
115+
push!(lines, "- **MKL Available**: $(get(system_info, "mkl_available", false))")
116+
push!(lines, "- **Apple Accelerate Available**: $(get(system_info, "apple_accelerate_available", false))")
117+
# Handle both "has_cuda" and "cuda_available" keys
118+
push!(lines, "- **CUDA Available**: $(get(system_info, "cuda_available", get(system_info, "has_cuda", false)))")
119+
# Handle both "has_metal" and "metal_available" keys
120+
push!(lines, "- **Metal Available**: $(get(system_info, "metal_available", get(system_info, "has_metal", false)))")
113121

114122
return join(lines, "\n")
115123
end

0 commit comments

Comments
 (0)