Merge pull request #288 from SciML/sparseview

Fix non-square sparse views

Author: ChrisRackauckas

src/factorization.jl

@@ -6,6 +6,22 @@ function _ldiv!(x::Vector, A::Factorization, b::Vector)
     ldiv!(A, x)
 end
 
+@static if VERSION >= v"1.9-"
+    function _ldiv!(x::AbstractVector, A::SparseArrays.SPQR.QRSparse, b::AbstractVector)
+        x .= A \ b
+    end
+    function _ldiv!(x::Vector, A::SparseArrays.SPQR.QRSparse, b::Vector)
+        x .= A \ b
+    end
+else
+    function _ldiv!(x::AbstractVector, A::SuiteSparse.SPQR.QRSparse, b::AbstractVector)
+        x .= A \ b
+    end
+    function _ldiv!(x::Vector, A::SuiteSparse.SPQR.QRSparse, b::Vector)
+        x .= A \ b
+    end
+end
+
 function SciMLBase.solve(cache::LinearCache, alg::AbstractFactorization; kwargs...)
     if cache.isfresh
         fact = do_factorization(alg, cache.A, cache.b, cache.u)

test/nonsquare.jl

@@ -24,3 +24,9 @@ b = rand(n)
 prob = LinearProblem(A, b)
 res = Matrix(A) \ b
 @test solve(prob, KrylovJL_CRAIGMR()) ≈ res
+
+A = sprandn(1000, 100, 0.1)
+b = randn(1001)
+prob = LinearProblem(A, view(b, 1:1000))
+linsolve = init(prob, QRFactorization())
+solve(linsolve)