Skip to content

Commit 7352372

Browse files
Hotfix v1.6 compatibility issues found and one typo
1 parent 45118a5 commit 7352372

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "LinearSolve"
22
uuid = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
33
authors = ["SciML"]
4-
version = "2.1.8"
4+
version = "2.1.9"
55

66
[deps]
77
ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/default.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ end
104104

105105
# A === nothing case
106106
function defaultalg(A, b::GPUArraysCore.AbstractGPUArray, assump::OperatorAssumptions)
107-
if assump.condition === OperatorConodition.IllConditioned || !assump.issq
107+
if assump.condition === OperatorCondition.IllConditioned || !assump.issq
108108
DefaultLinearSolver(DefaultAlgorithmChoice.QRFactorization)
109109
else
110110
@static if VERSION >= v"1.8-"

src/factorization.jl

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,13 @@ end
279279
assumptions::OperatorAssumptions)
280280
nothing
281281
end
282+
283+
function init_cacheval(alg::CholeskyFactorization,
284+
A::Adjoint{<:Array}, b, u, Pl, Pr,
285+
maxiters::Int, abstol, reltol, verbose::Bool,
286+
assumptions::OperatorAssumptions)
287+
nothing
288+
end
282289
end
283290

284291
## LDLtFactorization
@@ -865,7 +872,7 @@ function init_cacheval(alg::CHOLMODFactorization, A::SparseMatrixCSC{Float64, In
865872
PREALLOCATED_CHOLMOD
866873
end
867874

868-
function init_cacheval(alg::CHOLMODFactorization, A, b, u, Pl, Pr, maxiters::Int, abstol,
875+
function init_cacheval(alg::CHOLMODFactorization, A::SparseMatrixCSC{Float32, Int}, b, u, Pl, Pr, maxiters::Int, abstol,
869876
reltol,
870877
verbose::Bool, assumptions::OperatorAssumptions)
871878
cholesky(SparseMatrixCSC(0, 0, [1], Int64[], eltype(A)[]))

0 commit comments

Comments
 (0)