Skip to content

Commit 8341ae3

Browse files
committed
use SciMLMessage for fallback to QR factorization
1 parent b0f7227 commit 8341ae3

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/default.jl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,9 @@ end
365365
newex = quote
366366
sol = SciMLBase.solve!(cache, $(algchoice_to_alg(alg)), args...; kwargs...)
367367
if sol.retcode === ReturnCode.Failure && alg.safetyfallback
368-
## TODO: Add verbosity logging here about using the fallback
368+
@SciMLMessage("LU factorization failed, falling back to QR factorization. `A` is potentially rank-deficient.",
369+
cache.verbose, :default_lu_fallback, :error_control)
370+
369371
sol = SciMLBase.solve!(
370372
cache, QRFactorization(ColumnNorm()), args...; kwargs...)
371373
SciMLBase.build_linear_solution(alg, sol.u, sol.resid, sol.cache;
@@ -385,7 +387,9 @@ end
385387

386388
sol = SciMLBase.solve!(cache, $(algchoice_to_alg(alg)), args...; kwargs...)
387389
if sol.retcode === ReturnCode.Failure && alg.safetyfallback
388-
## TODO: Add verbosity logging here about using the fallback
390+
@SciMLMessage("LU factorization failed, falling back to QR factorization. `A` is potentially rank-deficient.",
391+
cache.verbose, :default_lu_fallback, :error_control)
392+
389393
sol = SciMLBase.solve!(
390394
cache, QRFactorization(ColumnNorm()), args...; kwargs...)
391395
SciMLBase.build_linear_solution(alg, sol.u, sol.resid, sol.cache;

0 commit comments

Comments
 (0)