clean up tests

Author: vpuri3

test/runtests.jl

@@ -15,28 +15,21 @@ using Test
     prob2 = LinearProblem(A2, b2; u0=x2)
     prob3 = LinearProblem(A3, b3; u0=x3)
 
-    for alg in (
-                :LUFactorization,
-                :QRFactorization,
-                :SVDFactorization,
-
-#               :DefaultLinSolve,
+    function test_interface(alg, kwargs, prob1, prob2, prob3)
+        A1 = prob1.A; b1 = prob1.b; x1 = prob1.u0
+        A2 = prob2.A; b2 = prob2.b; x2 = prob2.u0
+        A3 = prob3.A; b3 = prob3.b; x3 = prob3.u0
 
-                :KrylovJL, :KrylovJL_CG, :KrylovJL_GMRES, :KrylovJL_BICGSTAB,
-                :KrylovJL_MINRES,
-                :IterativeSolversJL, :IterativeSolversJL_GMRES,
-                :IterativeSolversJL_BICGSTAB, :IterativeSolversJL_MINRES
-               )
         @eval begin
-            y = solve($prob1, $alg())
+            y = solve($prob1, $alg($kwargs...))
             @test $A1 *  y  ≈ $b1 # out of place
             @test $A1 * $x1 ≈ $b1 # in place
 
-            y = $alg()($x2, $A2, $b2)              # alg is callable
+            y = $alg($kwargs...)($x2, $A2, $b2)    # alg is callable
             @test $A2 *  y  ≈ $b2
             @test $A2 * $x2 ≈ $b2
 
-            cache = SciMLBase.init($prob1, $alg()) # initialize cache
+            cache = SciMLBase.init($prob1, $alg($kwargs...)) # initialize cache
             y = cache($x3, $A1, $b1)               # cache is callable
             @test $A1 *  y  ≈ $b1
             @test $A1 * $x3 ≈ $b1
@@ -49,6 +42,42 @@ using Test
             @test $A2 *  y  ≈ $b3                  # same old cache
             @test $A2 * $x3 ≈ $b3
         end
+
+        return
+    end
+
+    # Factorizations
+    kwargs = :()
+    for alg in (
+                :LUFactorization,
+                :QRFactorization,
+                :SVDFactorization,
+               )
+        test_interface(alg, kwargs, prob1, prob2, prob3)
+    end
+
+    # KrylovJL
+    kwargs = :(verbose=1, abstol=1e-1, reltol=1e-1, maxiters=3, restart=5)
+    for alg in (
+                :KrylovJL,
+                :KrylovJL_CG,
+                :KrylovJL_GMRES,
+                :KrylovJL_BICGSTAB,
+                :KrylovJL_MINRES,
+               )
+        test_interface(alg, kwargs, prob1, prob2, prob3)
+    end
+
+    # IterativeSolversJL
+    kwargs = :(abstol=1e-1, reltol=1e-1, maxiters=3, restart=5)
+    for alg in (
+                :IterativeSolversJL,
+                :IterativeSolversJL_CG,
+                :IterativeSolversJL_GMRES,
+                :IterativeSolversJL_BICGSTAB,
+                :IterativeSolversJL_MINRES,
+               )
+        test_interface(alg, kwargs, prob1, prob2, prob3)
     end
 
 end