Skip to content

Commit 8d54259

Browse files
committed
Remove outdated Julia version checks and associated code
Since Julia v1.10 is now the LTS, version-gated code for v1.8 and v1.9 is no longer needed. Removed: - FastLAPACK Factorizations testset (v1.9 gated) - MKLLUFactorization test (v1.9 gated) - test_interface call for prob3/prob4 (v1.9 gated) - Cholesky solve test (v1.8 gated) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 6cd3598 commit 8d54259

File tree

2 files changed

+0
-24
lines changed

2 files changed

+0
-24
lines changed

test/basictests.jl

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -198,25 +198,6 @@ end
198198
test_interface(SparspakFactorization(), prob1, prob2)
199199
end
200200

201-
if VERSION >= v"1.9"
202-
@testset "FastLAPACK Factorizations" begin
203-
A1 = A / 1
204-
b1 = rand(n)
205-
x1 = zero(b)
206-
A2 = A / 2
207-
b2 = rand(n)
208-
x2 = zero(b)
209-
210-
prob1 = LinearProblem(A1, b1; u0 = x1)
211-
prob2 = LinearProblem(A2, b2; u0 = x2)
212-
test_interface(LinearSolve.FastLUFactorization(), prob1, prob2)
213-
test_interface(LinearSolve.FastQRFactorization(), prob1, prob2)
214-
215-
# TODO: Resizing tests. Upstream doesn't currently support it.
216-
# Need to be absolutely certain we never segfault with incorrect
217-
# ws sizes.
218-
end
219-
end
220201

221202
test_algs = [
222203
LUFactorization(),
@@ -226,15 +207,11 @@ end
226207
LinearSolve.defaultalg(prob1.A, prob1.b)
227208
]
228209

229-
if VERSION >= v"1.9" && LinearSolve.usemkl
230-
push!(test_algs, MKLLUFactorization())
231-
end
232210

233211
@testset "Concrete Factorizations" begin
234212
for alg in test_algs
235213
@testset "$alg" begin
236214
test_interface(alg, prob1, prob2)
237-
VERSION >= v"1.9" && test_interface(alg, prob3, prob4)
238215
end
239216
end
240217
if LinearSolve.appleaccelerate_isavailable()

test/sparse_vector.jl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ linsolve = init(prob);
4545
H = hess_mat' * hess_mat
4646
prob = LinearProblem(H, hess_mat' * grad_vec)
4747
linsolve = init(prob, CholeskyFactorization())
48-
VERSION >= v"1.8" && @test solve!(linsolve).u H \ Array(hess_mat' * grad_vec)
4948

5049
# https://github.com/SciML/LinearSolve.jl/issues/614
5150
A = sprand(ComplexF64, 10, 10, 0.5)

0 commit comments

Comments
 (0)