Use gh_cli_jll for automatic authentication

- Added gh_cli_jll as a dependency
- Implemented get_gh_command() to select between system gh and JLL gh
- Updated all gh CLI calls to use the wrapper function
- Auto-login now works even when gh is not installed on the system
- Falls back to JLL-provided gh binary automatically

This ensures the auto-authentication feature works on all systems, regardless of whether gh CLI is installed.

Author: ChrisRackauckas

lib/LinearSolveAutotune/Project.toml

@@ -10,6 +10,7 @@ Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
 CPUSummary = "2a0fbf3d-bb9c-48f3-b0a9-814d99fd7ab9"
 DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
 GitHub = "bc5e4493-9b4d-5f90-b8aa-2b2bcaad7a26"
+gh_cli_jll = "5d31d589-30fb-542f-b82d-10325e863e38"
 Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
 PrettyTables = "08abe8d2-0d0c-5749-adfa-8a2ac140af0d"
 Preferences = "21216c6a-2e73-6563-6e65-726566657250"
@@ -33,6 +34,7 @@ Base64 = "1"
 CPUSummary = "0.2"
 DataFrames = "1"
 GitHub = "5"
+gh_cli_jll = "2"
 Plots = "1"
 PrettyTables = "2"
 Preferences = "1"

lib/LinearSolveAutotune/src/LinearSolveAutotune.jl

@@ -24,6 +24,7 @@ using Metal
 
 # Optional dependencies for telemetry and plotting
 using GitHub
+using gh_cli_jll
 using Plots
 
 export autotune_setup, share_results, AutotuneResults, plot

lib/LinearSolveAutotune/src/telemetry.jl

@@ -1,5 +1,21 @@
 # Telemetry functionality for sharing benchmark results
 
+"""
+    get_gh_command()
+
+Get the gh command, preferring the system-installed version if available,
+falling back to the JLL-provided version.
+"""
+function get_gh_command()
+    # First check if gh is installed on the system
+    if !isnothing(Sys.which("gh"))
+        return `gh`
+    else
+        # Use the JLL-provided gh
+        return `$(gh_cli_jll.gh())`
+    end
+end
+
 """
     setup_github_authentication(; auto_login::Bool = true)
 
@@ -8,21 +24,22 @@ If auto_login is true and no authentication is found, will prompt to run gh auth
 Returns an authentication method indicator if successful, nothing if setup fails.
 """
 function setup_github_authentication(; auto_login::Bool = true)
-    # 1. Check for `gh` CLI
-    if !isnothing(Sys.which("gh"))
-        try
-            # Suppress output of gh auth status check
-            if success(pipeline(`gh auth status`; stdout=devnull, stderr=devnull))
-                # Check if logged in to github.com
-                auth_status_output = read(`gh auth status`, String)
-                if contains(auth_status_output, "Logged in to github.com")
-                    println("✅ Found active `gh` CLI session. Will use it for upload.")
-                    return (:gh_cli, "GitHub CLI")
-                end
+    # 1. Check for `gh` CLI (system or JLL)
+    gh_cmd = get_gh_command()
+    
+    # First check if already authenticated
+    try
+        # Suppress output of gh auth status check
+        if success(pipeline(`$gh_cmd auth status`; stdout=devnull, stderr=devnull))
+            # Check if logged in to github.com
+            auth_status_output = read(`$gh_cmd auth status`, String)
+            if contains(auth_status_output, "Logged in to github.com")
+                println("✅ Found active `gh` CLI session. Will use it for upload.")
+                return (:gh_cli, "GitHub CLI")
             end
-        catch e
-            @debug "gh CLI check failed: $e"
         end
+    catch e
+        @debug "gh CLI auth status check failed: $e"
     end
 
     # 2. Check for GITHUB_TOKEN environment variable
@@ -34,8 +51,8 @@ function setup_github_authentication(; auto_login::Bool = true)
         end
     end
 
-    # 3. If auto_login is enabled and gh is installed, offer to authenticate
-    if auto_login && !isnothing(Sys.which("gh"))
+    # 3. If auto_login is enabled, offer to authenticate
+    if auto_login
         println("\n🔐 GitHub authentication not found.")
         println("   To share results with the community, authentication is required.")
         println("\nWould you like to authenticate with GitHub now? (y/n)")
@@ -48,12 +65,12 @@ function setup_github_authentication(; auto_login::Bool = true)
             println("   Please follow the prompts to complete authentication.\n")
 
             try
-                # Run gh auth login interactively
-                run(`gh auth login`)
+                # Run gh auth login interactively (using system gh or JLL)
+                run(`$gh_cmd auth login`)
 
                 # Check if authentication succeeded
-                if success(pipeline(`gh auth status`; stdout=devnull, stderr=devnull))
-                    auth_status_output = read(`gh auth status`, String)
+                if success(pipeline(`$gh_cmd auth status`; stdout=devnull, stderr=devnull))
+                    auth_status_output = read(`$gh_cmd auth status`, String)
                     if contains(auth_status_output, "Logged in to github.com")
                         println("\n✅ Authentication successful! You can now share results.")
                         return (:gh_cli, "GitHub CLI")
@@ -569,6 +586,7 @@ function upload_plots_to_gist_gh(plot_files::Union{Nothing, Tuple, Dict}, eltype
     end
 
     try
+        gh_cmd = get_gh_command()
         # Handle different plot_files formats
         files_to_upload = if isa(plot_files, Tuple)
             # Legacy format: (png_file, pdf_file)
@@ -622,7 +640,7 @@ The PNG images can be viewed directly in the browser. Click on any `.png` file a
         # Create initial gist with README
         out = Pipe()
         err = Pipe()
-        run(pipeline(`gh gist create -d $gist_desc -p $readme_file`, stdout=out, stderr=err))
+        run(pipeline(`$gh_cmd gist create -d $gist_desc -p $readme_file`, stdout=out, stderr=err))
         close(out.in)
         close(err.in)
 
@@ -640,7 +658,7 @@ The PNG images can be viewed directly in the browser. Click on any `.png` file a
         temp_dir = mktempdir()
         try
             # Clone the gist
-            run(`gh gist clone $gist_id $temp_dir`)
+            run(`$gh_cmd gist clone $gist_id $temp_dir`)
 
             # Copy all plot files to the gist directory
             for (name, filepath) in existing_files
@@ -659,7 +677,7 @@ The PNG images can be viewed directly in the browser. Click on any `.png` file a
 
             # Get username for constructing raw URLs
             username_out = Pipe()
-            run(pipeline(`gh api user --jq .login`, stdout=username_out))
+            run(pipeline(`$gh_cmd api user --jq .login`, stdout=username_out))
             close(username_out.in)
             username = strip(read(username_out, String))
 
@@ -710,13 +728,14 @@ function comment_on_issue_gh(target_repo, issue_number, body)
     err_str = ""
     out_str = ""
     try
+        gh_cmd = get_gh_command()
         # Use a temporary file for the body to avoid command line length limits
         mktemp() do path, io
             write(io, body)
             flush(io)
 
             # Construct and run the gh command
-            cmd = `gh issue comment $issue_number --repo $target_repo --body-file $path`
+            cmd = `$gh_cmd issue comment $issue_number --repo $target_repo --body-file $path`
 
             out = Pipe()
             err = Pipe()
@@ -762,13 +781,14 @@ function create_benchmark_issue_gh(target_repo, title, body)
     err_str = ""
     out_str = ""
     try
+        gh_cmd = get_gh_command()
         # Use a temporary file for the body to avoid command line length limits
         mktemp() do path, io
             write(io, body)
             flush(io)
 
             # Construct and run the gh command
-            cmd = `gh issue create --repo $target_repo --title $title --body-file $path --label benchmark-data`
+            cmd = `$gh_cmd issue create --repo $target_repo --title $title --body-file $path --label benchmark-data`
 
             out = Pipe()
             err = Pipe()