Use LP64 BLAS and LAPACK from Accelerate

These should always be available everywhere.

Author: ViralBShah

Project.toml

@@ -12,6 +12,7 @@ GPUArraysCore = "46192b85-c4d5-4398-a991-12ede77f4527"
 InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
 KLU = "ef3ab10e-7fda-4108-b977-705223b18434"
 Krylov = "ba0b0d4f-ebba-5204-a429-3ac8c609bfb7"
+Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
 Preferences = "21216c6a-2e73-6563-6e65-726566657250"

src/appleaccelerate.jl

@@ -1,3 +1,6 @@
+using LinearAlgebra
+using Libdl
+
 # For now, only use BLAS from Accelerate (that is to say, vecLib)
 global const libacc = "/System/Library/Frameworks/Accelerate.framework/Accelerate"
 
@@ -12,33 +15,33 @@ to avoid allocations and does not require libblastrampoline.
 struct AppleAccelerateLUFactorization <: AbstractFactorization end
 
 function appleaccelerate_isavailable()
-    libacc_hdl = dlopen_e(libacc)
+    libacc_hdl = Libdl.dlopen_e(libacc)
     if libacc_hdl == C_NULL
         return false
     end
 
-    if dlsym_e(libacc_hdl, "dgemm\$NEWLAPACK\$ILP64") == C_NULL
+    if dlsym_e(libacc_hdl, "dgetrf_") == C_NULL
         return false
     end
     return true
 end
 
-function aa_getrf!(A::AbstractMatrix{<:Float64}; ipiv = similar(A, BlasInt, min(size(A,1),size(A,2))), info = Ref{BlasInt}(), check = false)
+function aa_getrf!(A::AbstractMatrix{<:Float64}; ipiv = similar(A, Cint, min(size(A,1),size(A,2))), info = Ref{Cint}(), check = false)
     require_one_based_indexing(A)
     check && chkfinite(A)
     chkstride1(A)
     m, n = size(A)
     lda  = max(1,stride(A, 2))
     if isempty(ipiv)
-        ipiv = similar(A, BlasInt, min(size(A,1),size(A,2)))
+        ipiv = similar(A, Cint, min(size(A,1),size(A,2)))
     end
 
-    ccall(("dgetrf\$NEWLAPACK\$ILP64", libacc), Cvoid,
-            (Ref{BlasInt}, Ref{BlasInt}, Ptr{Float64},
-            Ref{BlasInt}, Ptr{BlasInt}, Ptr{BlasInt}),
+    ccall(("dgetrf_", libacc), Cvoid,
+            (Ref{Cint}, Ref{Cint}, Ptr{Float64},
+            Ref{Cint}, Ptr{Cint}, Ptr{Cint}),
             m, n, A, lda, ipiv, info)
-    chkargsok(info[])
-    A, ipiv, info[] #Error code is stored in LU factorization type
+    info[] < 0 && throw(ArgumentError("Invalid arguments sent to LAPACK dgetrf_"))
+    A, Vector{BlasInt}(ipiv), BlasInt(info[]) #Error code is stored in LU factorization type
 end
 
 default_alias_A(::AppleAccelerateLUFactorization, ::Any, ::Any) = false
@@ -62,4 +65,4 @@ function SciMLBase.solve!(cache::LinearCache, alg::AppleAccelerateLUFactorizatio
     end
     y = ldiv!(cache.u, @get_cacheval(cache, :AppleAccelerateLUFactorization), cache.b)
     SciMLBase.build_linear_solution(alg, y, nothing, cache)
-end
+end