reverting

Author: vpuri3

src/LinearSolve.jl

@@ -17,7 +17,7 @@ using DocStringExtensions
 
 # wrap
 import Krylov
-import KrylovKit # TODO
+import KrylovKit
 import IterativeSolvers
 
 using Reexport

src/default.jl

@@ -53,19 +53,11 @@ end
 
 function SciMLBase.solve(cache::LinearCache, alg::Nothing,
                          args...; kwargs...)
-    @unpack A, b, u = cache
+    @unpack A = cache
     if A isa DiffEqArrayOperator
         A = A.A
     end
 
-    if applicable(ldiv!, u, A, b)
-        alg = LdivBang3Args()
-        SciMLBase.solve(cache, alg, args...; kwargs...)
-    elseif applicable(ldiv!, A, u)
-        alg = LdivBang2Args()
-        SciMLBase.solve(cache, alg, args...; kwargs...)
-    end
-
     # Special case on Arrays: avoid BLAS for RecursiveFactorization.jl when
     # it makes sense according to the benchmarks, which is dependent on
     # whether MKL or OpenBLAS is being used
@@ -125,14 +117,6 @@ function init_cacheval(alg::Nothing, A, b, u, Pl, Pr, maxiters, abstol, reltol,
         A = A.A
     end
 
-    if applicable(ldiv!, A, u)
-        alg = FunctionCall(ldiv!, (:A, :u))
-        init_cacheval(alg, A, b, u, Pl, Pr, maxiters, abstol, reltol, verbose)
-    elseif applicable(ldiv!, u, A, b)
-        alg = FunctionCall(ldiv!, (:u, :A, :b))
-        init_cacheval(alg, A, b, u, Pl, Pr, maxiters, abstol, reltol, verbose)
-    end
-
     # Special case on Arrays: avoid BLAS for RecursiveFactorization.jl when
     # it makes sense according to the benchmarks, which is dependent on
     # whether MKL or OpenBLAS is being used

test/basictests.jl

@@ -48,7 +48,6 @@ end
     y = solve(_prob)
     @test A1 *  y  ≈ b1
 
-    #=
     _prob = LinearProblem(SymTridiagonal(A1), b1; u0=x1)
     y = solve(_prob)
     @test A1 *  y  ≈ b1
@@ -69,10 +68,8 @@ end
     _prob = LinearProblem(sparse(A1), b1; u0=x1)
     y = solve(_prob)
     @test A1 *  y  ≈ b1
-    =#
 end
 
-#=
 @testset "UMFPACK Factorization" begin
     A1 = A/1; b1 = rand(n); x1 = zero(b)
     A2 = A/2; b2 = rand(n); x2 = zero(b)
@@ -289,6 +286,5 @@ end
     @test sol13.u ≈ sol23.u
     @test sol13.u ≈ sol33.u
 end
-=#
 
 end # testset