Skip to content

Commit c4ce1de

Browse files
Update JET tests that now pass with improved type stability
Several JET tests that were previously marked as broken now pass due to the type stability improvements in LinearVerbosity: - QRFactorization - LDLtFactorization - BunchKaufmanFactorization - FastLUFactorization - FastQRFactorization - KrylovJL_GMRES - KrylovJL_MINRES - KrylovJL_MINARES Changed from @test_opt broken=true to @test_opt for these passing tests.
1 parent 0621b14 commit c4ce1de

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

test/nopre/jet.jl

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -60,20 +60,20 @@ dual_prob = LinearProblem(A, b)
6060
# JET.@test_opt solve(prob_spd, CholeskyFactorization())
6161
# JET.@test_opt solve(prob, SVDFactorization())
6262

63-
# Tests with known type stability issues - marked as broken
64-
JET.@test_opt solve(prob, QRFactorization()) broken=true
65-
JET.@test_opt solve(prob_sym, LDLtFactorization()) broken=true
66-
JET.@test_opt solve(prob_sym, BunchKaufmanFactorization()) broken=true
63+
# These tests now pass with improved type stability
64+
JET.@test_opt solve(prob, QRFactorization())
65+
JET.@test_opt solve(prob_sym, LDLtFactorization())
66+
JET.@test_opt solve(prob_sym, BunchKaufmanFactorization())
6767
JET.@test_opt solve(prob, GenericFactorization()) broken=true
6868
end
6969

7070
@testset "JET Tests for Extension Factorizations" begin
7171
# RecursiveFactorization.jl extensions
7272
# JET.@test_opt solve(prob, RFLUFactorization())
73-
74-
# Tests with known type stability issues
75-
JET.@test_opt solve(prob, FastLUFactorization()) broken=true
76-
JET.@test_opt solve(prob, FastQRFactorization()) broken=true
73+
74+
# These tests now pass with improved type stability
75+
JET.@test_opt solve(prob, FastLUFactorization())
76+
JET.@test_opt solve(prob, FastQRFactorization())
7777

7878
# Platform-specific factorizations (may not be available on all systems)
7979
if @isdefined(MKLLUFactorization)
@@ -116,11 +116,11 @@ end
116116

117117
# SimpleGMRES passes JET tests
118118
# JET.@test_opt solve(prob, SimpleGMRES())
119-
120-
# KrylovJL methods with known type stability issues
121-
JET.@test_opt solve(prob, KrylovJL_GMRES()) broken=true
122-
JET.@test_opt solve(prob_sym, KrylovJL_MINRES()) broken=true
123-
JET.@test_opt solve(prob_sym, KrylovJL_MINARES()) broken=true
119+
120+
# These tests now pass with improved type stability
121+
JET.@test_opt solve(prob, KrylovJL_GMRES())
122+
JET.@test_opt solve(prob_sym, KrylovJL_MINRES())
123+
JET.@test_opt solve(prob_sym, KrylovJL_MINARES())
124124

125125
# Extension Krylov methods (require extensions)
126126
# KrylovKitJL_CG, KrylovKitJL_GMRES require KrylovKit to be loaded

0 commit comments

Comments
 (0)