Merge pull request #262 from chriselrod/rflu

Use `eltype(b)` if `A === nothing`

Author: ChrisRackauckas

src/default.jl

@@ -131,7 +131,8 @@ function defaultalg(A, b, ::OperatorAssumptions{true})
             if length(b) <= 10
                 alg = GenericLUFactorization()
             elseif (length(b) <= 100 || (isopenblas() && length(b) <= 500)) &&
-                   eltype(A) <: Union{Float32, Float64}
+                   (A === nothing ? eltype(b) <: Union{Float32, Float64} :
+                    eltype(A) <: Union{Float32, Float64})
                 alg = RFLUFactorization()
                 #elseif A === nothing || A isa Matrix
                 #    alg = FastLUFactorization()

test/default_algs.jl

@@ -0,0 +1,13 @@
+using LinearSolve, LinearAlgebra, SparseArrays, Test
+@test LinearSolve.defaultalg(nothing, zeros(3)) isa GenericLUFactorization
+@test LinearSolve.defaultalg(nothing, zeros(50)) isa RFLUFactorization
+@test LinearSolve.defaultalg(nothing, zeros(600)) isa LUFactorization
+@test LinearSolve.defaultalg(LinearAlgebra.Diagonal(zeros(5)), zeros(5)) isa
+      DiagonalFactorization
+
+@test LinearSolve.defaultalg(nothing, zeros(5),
+                             LinearSolve.OperatorAssumptions{false}()) isa QRFactorization
+
+@test LinearSolve.defaultalg(sprand(1000, 1000, 0.01), zeros(1000)) isa KLUFactorization
+@test LinearSolve.defaultalg(sprand(11000, 11000, 0.001), zeros(11000)) isa
+      UMFPACKFactorization

test/runtests.jl

@@ -25,6 +25,7 @@ if GROUP == "All" || GROUP == "Core"
     @time @safetestset "Zero Initialization Tests" begin include("zeroinittests.jl") end
     @time @safetestset "Non-Square Tests" begin include("nonsquare.jl") end
     @time @safetestset "SparseVector b Tests" begin include("sparse_vector.jl") end
+    @time @safetestset "Default Alg Tests" begin include("default_algs.jl") end
 end
 
 if GROUP == "LinearSolveCUDA"