Skip to content

Commit e6e2b5e

Browse files
committed
cleanup
1 parent 4da0888 commit e6e2b5e

File tree

1 file changed

+19
-12
lines changed

1 file changed

+19
-12
lines changed

src/wrappers.jl

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -39,19 +39,19 @@ struct KrylovJL{F,Tl,Tr,T,I,A,K} <: AbstractKrylovSubspaceMethod
3939
reltol::T
4040
maxiter::I
4141
ifverbose::Bool
42-
restart::I
42+
gmres_restart::I
4343
window::I
4444
args::A
4545
kwargs::K
4646
end
4747

4848
function KrylovJL(args...; KrylovAlg = Krylov.gmres!, Pl=I, Pr=I,
4949
abstol=0.0, reltol=0.0, maxiter=0, ifverbose=false,
50-
restart=20, window=0, # for building solver
50+
gmres_restart=20, window=0, # for building solver
5151
kwargs...)
5252

5353
return KrylovJL(KrylovAlg, Pl, Pr, abstol, reltol, maxiter, ifverbose,
54-
restart, window,
54+
gmres_restart, window,
5555
args, kwargs)
5656
end
5757

@@ -108,7 +108,7 @@ function init_cacheval(alg::KrylovJL, A, b, u)
108108
KS === Krylov.GmresSolver ||
109109
KS === Krylov.FomSolver
110110
)
111-
KS(A, b, alg.restart)
111+
KS(A, b, alg.gmres_restart)
112112
elseif(KS === Krylov.MinresSolver ||
113113
KS === Krylov.SymmlqSolver ||
114114
KS === Krylov.LslqSolver ||
@@ -136,7 +136,6 @@ function SciMLBase.solve(cache::LinearCache, alg::KrylovJL; kwargs...)
136136
maxiter = (alg.maxiter == 0) ? length(cache.b) : alg.maxiter
137137
verbose = alg.ifverbose ? 1 : 0
138138

139-
140139
args = (cache.cacheval, cache.A, cache.b)
141140
kwargs = (atol=abstol, rtol=reltol, itmax=maxiter, verbose=verbose,
142141
alg.kwargs...)
@@ -174,7 +173,7 @@ struct IterativeSolversJL{F,Tl,Tr,T,I,A,K} <: AbstractKrylovSubspaceMethod
174173
reltol::T
175174
maxiter::I
176175
ifverbose::Bool
177-
restart::I
176+
gmres_restart::I
178177
args::A
179178
kwargs::K
180179
end
@@ -184,20 +183,28 @@ function IterativeSolversJL(args...;
184183
Pl=IterativeSolvers.Identity(),
185184
Pr=IterativeSolvers.Identity(),
186185
abstol=0.0, reltol=0.0, maxiter=0, ifverbose=true,
187-
restart=0, kwargs...)
186+
gmres_restart=0, kwargs...)
188187
return IterativeSolversJL(generate_iterator, Pl, Pr,
189188
abstol, reltol, maxiter, ifverbose,
190-
restart, args, kwargs)
189+
gmres_restart, args, kwargs)
191190
end
192191

193192
IterativeSolversJL_CG(args...; kwargs...) =
194-
IterativeSolversJL(args...; generate_iterator=IterativeSolvers.cg_iterator!, kwargs...)
193+
IterativeSolversJL(args...;
194+
generate_iterator=IterativeSolvers.cg_iterator!,
195+
kwargs...)
195196
IterativeSolversJL_GMRES(args...;kwargs...) =
196-
IterativeSolversJL(args...; generate_iterator=IterativeSolvers.gmres_iterable!, kwargs...)
197+
IterativeSolversJL(args...;
198+
generate_iterator=IterativeSolvers.gmres_iterable!,
199+
kwargs...)
197200
IterativeSolversJL_BICGSTAB(args...;kwargs...) =
198-
IterativeSolversJL(args...; generate_iterator=IterativeSolvers.bicgstabl_iterator!, kwargs...)
201+
IterativeSolversJL(args...;
202+
generate_iterator=IterativeSolvers.bicgstabl_iterator!,
203+
kwargs...)
199204
IterativeSolversJL_MINRES(args...;kwargs...) =
200-
IterativeSolversJL(args...; generate_iterator=IterativeSolvers.minres_iterable!, kwargs...)
205+
IterativeSolversJL(args...;
206+
generate_iterator=IterativeSolvers.minres_iterable!,
207+
kwargs...)
201208

202209
function init_cacheval(alg::IterativeSolversJL, A, b, u)
203210
Pl = (alg.Pl == LinearAlgebra.I) ? IterativeSolvers.Identity() : alg.Pl

0 commit comments

Comments
 (0)