Skip to content

Fix defaultalg method ambiguity for SciMLOp + GPUArray #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vpuri3 wants to merge 1 commit into from
Closed

Fix defaultalg method ambiguity for SciMLOp + GPUArray #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/default.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function defaultalg(A::GPUArraysCore.AbstractGPUArray, b::GPUArraysCore.Abstract
end
end

function defaultalg(A::SciMLBase.AbstractSciMLOperator, b,
function _defaultalg_scimlops(A::SciMLBase.AbstractSciMLOperator, b,
assump::OperatorAssumptions)
if has_ldiv!(A)
return DefaultLinearSolver(DefaultAlgorithmChoice.DirectLdiv!)
Expand All @@ -145,6 +145,9 @@ function defaultalg(A::SciMLBase.AbstractSciMLOperator, b,
end
end

defaultalg(A::SciMLBase.AbstractSciMLOperator, b, assump::OperatorAssumptions) = _defaultalg_scimlops(A, b, assump)
defaultalg(A::SciMLBase.AbstractSciMLOperator, b::GPUArraysCore.AbstractGPUArray, assump::OperatorAssumptions) = _defaultalg_scimlops(A, b, assump)

# Allows A === nothing as a stand-in for dense matrix
function defaultalg(A, b, assump::OperatorAssumptions)
alg = if assump.issq
Expand Down