Skip to content

Commit 19e8a89

Browse files
committed
Disable just the faulty branch of the early return optimization, since DDEs rely on the other branch
1 parent 93d13fb commit 19e8a89

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/utils.jl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -665,8 +665,7 @@ function promote_to_concrete(vs; tofloat = true, use_union = true)
665665
T = eltype(vs)
666666

667667
# return early if there is nothing to do
668-
# TODO: reenable after it was disabled to fix missing errors in https://github.com/SciML/ModelingToolkit.jl/issues/2873
669-
#Base.isconcretetype(T) && (!tofloat || T === float(T)) && return vs
668+
Base.isconcretetype(T) && (!tofloat#= || T === float(T)=#) && return vs # TODO: disabled float(T) to restore missing errors in https://github.com/SciML/ModelingToolkit.jl/issues/2873
670669

671670
sym_vs = filter(x -> SymbolicUtils.issym(x) || SymbolicUtils.iscall(x), vs)
672671
isempty(sym_vs) || throw_missingvars_in_sys(sym_vs)

0 commit comments

Comments
 (0)