Added validation to OptimizationSystem.

Author: Lucas Morton

docs/src/basics/Validation.md

@@ -63,7 +63,7 @@ eqs = eqs = [D(E) ~ P - E/τ,
 ModelingToolkit.validate(eqs) #Returns false while displaying a warning message
 ```
 
-## `Unitful` Literals & User-defined functions
+## `Unitful` Literals & User-Defined Functions
 
 In order for a function to work correctly during both validation & execution, the function must be unit-agnostic. That is, no unitful literals may be used. Any unitful quantity must either be a `parameter` or `variable`. For example, these equations will not validate successfully. 
 

src/systems/optimization/optimizationsystem.jl

@@ -42,6 +42,12 @@ struct OptimizationSystem <: AbstractTimeIndependentSystem
     """
     defaults::Dict
     function OptimizationSystem(op, states, ps, var_to_name, observed, equality_constraints, inequality_constraints, name, systems, defaults; checks::Bool = true)
+        if checks
+            check_units(op)
+            check_units(observed)
+            check_units(equality_constraints)
+            check_units(inequality_constraints)
+        end
         new(op, states, ps, var_to_name, observed, equality_constraints, inequality_constraints, name, systems, defaults)
     end
 end

src/systems/validation.jl

@@ -132,6 +132,7 @@ validate(eqs::Vector; info::String = "") = all([validate(eqs[idx], info = info*"
 validate(eqs::Vector, noise::Vector; info::String = "") = all([validate(eqs[idx], noise[idx], info = info*" in eq. #$idx") for idx in 1:length(eqs)])
 validate(eqs::Vector, noise::Matrix; info::String = "") = all([validate(eqs[idx], noise[idx, :], info = info*" in eq. #$idx") for idx in 1:length(eqs)])
 validate(eqs::Vector, term::Symbolic; info::String = "") = all([validate(eqs[idx], term, info = info*" in eq. #$idx") for idx in 1:length(eqs)])
+validate(term::Symbolics.SymbolicUtils.Symbolic) = safe_get_unit(term,"") !== nothing
 
 "Throws error if units of equations are invalid."
 check_units(eqs...) = validate(eqs...) || throw(ValidationError("Some equations had invalid units. See warnings for details."))