fix: fix DEF parameters for split = true, flatten = false systems

Author: AayushSabharwal

src/systems/abstractsystem.jl

@@ -753,7 +753,9 @@ function complete(sys::AbstractSystem; split = true, flatten = true)
     end
     if split && has_index_cache(sys)
         @set! sys.index_cache = IndexCache(sys)
-        all_ps = get_ps(sys)
+        # Ideally we'd do `get_ps` but if `flatten = false`
+        # we don't get all of them. So we call `parameters`.
+        all_ps = parameters(sys; initial_parameters = true)
         if !isempty(all_ps)
             # reorder parameters by portions
             ps_split = reorder_parameters(sys, all_ps)

test/split_parameters.jl

@@ -268,3 +268,40 @@ end
         @test_nowarn sol = solve(prob)
     end
 end
+
+@testset "" begin
+    @mtkmodel SubSystem begin
+        @parameters begin
+            c = 1
+        end
+        @variables begin
+            x(t)
+        end
+        @equations begin
+            D(x) ~ c * x
+        end
+    end
+
+    @mtkmodel System begin
+        @components begin
+            subsys = SubSystem()
+        end
+        @parameters begin
+            k = 1
+        end
+        @variables begin
+            y(t)
+        end
+        @equations begin
+            D(y) ~ k * y + subsys.x
+        end
+    end
+
+    @named sys = System()
+    sysref = complete(sys)
+    sys2 = complete(sys; split = true, flatten = false)
+    ps = Set(full_parameters(sys2))
+    @test sysref.k in ps
+    @test sysref.subsys.c in ps
+    @test length(ps) == 2
+end