Merge pull request #899 from pepijndevos/sanitycheck

Add check to avoid accidental singulatity error after structural_simplify

Author: YingboMa

src/systems/diffeqs/abstractodesystem.jl

@@ -291,6 +291,8 @@ function process_DEProblem(constructor, sys::AbstractODESystem,u0map,parammap;
     u0 = varmap_to_vars(u0map,dvs; defaults=defs)
     p = varmap_to_vars(parammap,ps; defaults=defs)
 
+    length(dvs) == length(u0) || throw(ArgumentError("States ($(length(dvs))) and initial conditions ($(length(u0))) are of different lengths."))
+
     f = constructor(sys,dvs,ps,u0;tgrad=tgrad,jac=jac,checkbounds=checkbounds,
                     linenumbers=linenumbers,parallel=parallel,simplify=simplify,
                     sparse=sparse,eval_expression=eval_expression,kwargs...)

src/systems/nonlinear/nonlinearsystem.jl

@@ -211,6 +211,8 @@ function process_NonlinearProblem(constructor, sys::NonlinearSystem,u0map,paramm
     u0 = varmap_to_vars(u0map,dvs; defaults=defs)
     p = varmap_to_vars(parammap,ps; defaults=defs)
 
+    length(dvs) == length(u0) || throw(ArgumentError("States ($(length(dvs))) and initial conditions ($(length(u0))) are of different lengths."))
+
     f = constructor(sys,dvs,ps,u0;jac=jac,checkbounds=checkbounds,
                     linenumbers=linenumbers,parallel=parallel,simplify=simplify,
                     sparse=sparse,eval_expression=eval_expression,kwargs...)

test/nonlinearsystem.jl

@@ -75,6 +75,8 @@ prob = NonlinearProblem(ns,ones(3),ones(3))
 sol = solve(prob,NewtonRaphson())
 @test sol.u[1] ≈ sol.u[2]
 
+@test_throws ArgumentError NonlinearProblem(ns,ones(4),ones(3))
+
 @variables u F s a
 eqs1 = [
         0 ~ σ*(y-x) + F,

test/odesystem.jl

@@ -230,6 +230,7 @@ for (prob, atol) in [(prob1, 1e-12), (prob2, 1e-12), (prob3, 1e-12)]
     sol = solve(prob, Rodas5())
     @test all(x->≈(sum(x), 1.0, atol=atol), sol.u)
 end
+@test_throws ArgumentError ODEProblem(sys,zeros(5),tspan,p)
 
 @parameters t σ β
 @variables x(t) y(t) z(t)