Skip to content

Commit 5b8cc35

Browse files
Merge pull request #3495 from vyudu/document_DAE
docs: Document DAEProblem constructor
2 parents b5ff7da + 0f1c669 commit 5b8cc35

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

docs/src/systems/ODESystem.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ jacobian_sparsity
6262
ODEFunction(sys::ModelingToolkit.AbstractODESystem, args...)
6363
ODEProblem(sys::ModelingToolkit.AbstractODESystem, args...)
6464
SteadyStateProblem(sys::ModelingToolkit.AbstractODESystem, args...)
65+
DAEProblem(sys::ModelingToolkit.AbstractODESystem, args...)
6566
```
6667

6768
## Expression Constructors

src/systems/diffeqs/abstractodesystem.jl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -941,6 +941,10 @@ DiffEqBase.DAEProblem{iip}(sys::AbstractODESystem, du0map, u0map, tspan,
941941
942942
Generates a DAEProblem from an ODESystem and allows for automatically
943943
symbolically calculating numerical enhancements.
944+
945+
Note: Solvers for DAEProblems like DFBDF, DImplicitEuler, DABDF2 are
946+
generally slower than the ones for ODEProblems. We recommend trying
947+
ODEProblem and its solvers for your problem first.
944948
"""
945949
function DiffEqBase.DAEProblem(sys::AbstractODESystem, args...; kwargs...)
946950
DAEProblem{true}(sys, args...; kwargs...)
@@ -951,7 +955,7 @@ function DiffEqBase.DAEProblem{iip}(sys::AbstractODESystem, du0map, u0map, tspan
951955
warn_initialize_determined = true,
952956
check_length = true, eval_expression = false, eval_module = @__MODULE__, kwargs...) where {iip}
953957
if !iscomplete(sys)
954-
error("A completed system is required. Call `complete` or `structural_simplify` on the system before creating a `DAEProblem`")
958+
error("A completed system is required. Call `complete` or `structural_simplify` on the system before creating a `DAEProblem`.")
955959
end
956960
f, du0, u0, p = process_SciMLProblem(DAEFunction{iip}, sys, u0map, parammap;
957961
implicit_dae = true, du0map = du0map, check_length,

0 commit comments

Comments
 (0)