extra symbolic parameter tests

Author: pepijndevos

src/systems/abstractsystem.jl

@@ -184,7 +184,8 @@ end
 function Base.setproperty!(sys::AbstractSystem, prop::Symbol, val)
     if (pa = Sym{Parameter{Real}}(prop); pa in parameters(sys))
         sys.default_p[pa] = value(val)
-    elseif (st = Sym{Real}(prop); st in states(sys))
+    # comparing a Sym returns a symbolic expression
+    elseif (st = Sym{Real}(prop); any(s->s.name==st.name, states(sys)))
         sys.default_u0[st] = value(val)
     else
         setfield!(sys, prop, val)

test/symbolic_parameters.jl

@@ -14,30 +14,35 @@ par = [
     ρ => 0.1+σ,
     β => ρ*1.1
 ]
-u0 = [
+u0 = Pair{Num, Any}[
     x => u,
     y => u,
-    z => u,
+    z => u-0.1,
 ]
 ns = NonlinearSystem(eqs, [x,y,z],[σ,ρ,β], name=:ns, default_p=par, default_u0=u0)
+ns.y = u*1.1
 ModelingToolkit.default_p(ns)
 resolved = ModelingToolkit.varmap_to_vars(Dict(), parameters(ns), defaults=ModelingToolkit.default_p(ns))
 @test resolved == [1, 0.1+1, (0.1+1)*1.1]
 
 prob = NonlinearProblem(ns, [u=>1.0], Pair[])
+@test prob.u0 == [1.0, 1.1, 0.9]
 @show sol = solve(prob,NewtonRaphson())
 
 @variables a
 @parameters b
 top = NonlinearSystem([0 ~ -a + ns.x+b], [a], [b], systems=[ns], name=:top)
 top.b = ns.σ*0.5
+top.ns.x = u*0.5
 
 res = ModelingToolkit.varmap_to_vars(Dict(), parameters(top), defaults=ModelingToolkit.default_p(top))
 @test res == [0.5, 1, 0.1+1, (0.1+1)*1.1]
 
 prob = NonlinearProblem(top, [states(ns, u)=>1.0, a=>1.0], Pair[])
+@test prob.u0 == [1.0, 0.5, 1.1, 0.9]
 @show sol = solve(prob,NewtonRaphson())
 
 # test NullParameters+defaults
 prob = NonlinearProblem(top, [states(ns, u)=>1.0, a=>1.0])
+@test prob.u0 == [1.0, 0.5, 1.1, 0.9]
 @show sol = solve(prob,NewtonRaphson())