Merge pull request #1549 from SciML/myb/ob

Scalarize in observed function building

Author: YingboMa

src/structural_transformation/codegen.jl

@@ -386,7 +386,7 @@ function build_observed_function(
     if (isscalar = !(ts isa AbstractVector))
         ts = [ts]
     end
-    ts = Symbolics.scalarize.(value.(ts))
+    ts = unwrap.(Symbolics.scalarize(ts))
 
     vars = Set()
     sys = state.sys

src/systems/diffeqs/odesystem.jl

@@ -270,7 +270,7 @@ function build_explicit_observed_function(
     if (isscalar = !(ts isa AbstractVector))
         ts = [ts]
     end
-    ts = Symbolics.scalarize.(value.(ts))
+    ts = unwrap.(Symbolics.scalarize(ts))
 
     vars = Set()
     foreach(Base.Fix1(vars!, vars), ts)

test/nonlinearsystem.jl

@@ -177,3 +177,20 @@ eq = [
 ]
 @named sys = ODESystem(eq)
 @test length(equations(structural_simplify(sys))) == 0
+
+#1504
+let
+    @variables u[1:4]
+
+    eqs = [u[1] ~ 1,
+           u[2] ~ 1,
+           u[3] ~ 1,
+           u[4] ~ 1]
+
+    sys = NonlinearSystem(eqs, collect(u[1:4]), Num[], defaults=Dict([]), name=:test)
+    prob = NonlinearProblem(sys, ones(length(sys.states)))
+
+    sol = NonlinearSolve.solve(prob, NewtonRaphson())
+
+    @test sol[u] ≈ ones(4)
+end