refactor: remove old force_initialization_time_independent kwarg

Author: AayushSabharwal

src/problems/initializationproblem.jl

@@ -28,7 +28,6 @@ initial conditions for the given DAE.
         check_units = true,
         use_scc = true,
         allow_incomplete = false,
-        force_time_independent = false,
         algebraic_only = false,
         time_dependent_init = is_time_dependent(sys),
         kwargs...) where {iip, specialize}
@@ -58,7 +57,7 @@ initial conditions for the given DAE.
 
     # useful for `SteadyStateProblem` since `f` has to be autonomous and the
     # initialization should be too
-    if force_time_independent
+    if !time_dependent_init
         idx = findfirst(isequal(get_iv(sys)), get_ps(isys))
         idx === nothing || deleteat!(get_ps(isys), idx)
     end

src/problems/odeproblem.jl

@@ -91,7 +91,7 @@ end
 
     f, u0, p = process_SciMLProblem(ODEFunction{iip}, sys, op;
         steady_state = true, check_length, check_compatibility, expression,
-        force_initialization_time_independent = true, kwargs...)
+        time_dependent_init = false, kwargs...)
 
     kwargs = process_kwargs(sys; expression, kwargs...)
     args = (; f, u0, p)

src/systems/problem_utils.jl

@@ -1217,7 +1217,7 @@ function process_SciMLProblem(
         circular_dependency_max_cycle_length = length(all_symbols(sys)),
         circular_dependency_max_cycles = 10,
         substitution_limit = 100, use_scc = true, time_dependent_init = is_time_dependent(sys),
-        force_initialization_time_independent = false, algebraic_only = false,
+        algebraic_only = false,
         allow_incomplete = false, is_initializeprob = false, kwargs...)
     dvs = unknowns(sys)
     ps = parameters(sys; initial_parameters = true)
@@ -1276,8 +1276,8 @@ function process_SciMLProblem(
             eval_expression, eval_module, fully_determined,
             warn_cyclic_dependency, check_units = check_initialization_units,
             circular_dependency_max_cycle_length, circular_dependency_max_cycles, use_scc,
-            force_time_independent = force_initialization_time_independent, algebraic_only, allow_incomplete,
-            u0_constructor, p_constructor, floatT, time_dependent_init)
+            algebraic_only, allow_incomplete, u0_constructor, p_constructor, floatT,
+            time_dependent_init)
 
         kwargs = merge(kwargs, kws)
     end