refactor: remove outdated functions

refactor: remove `controls(sys)`

refactor: remove `solved_unknowns(sys)`

Author: AayushSabharwal

src/systems/abstractsystem.jl

@@ -282,7 +282,7 @@ function SymbolicIndexingInterface.variable_index(sys::AbstractSystem, sym::Symb
 end
 
 function SymbolicIndexingInterface.variable_symbols(sys::AbstractSystem)
-    return solved_unknowns(sys)
+    return unknowns(sys)
 end
 
 function SymbolicIndexingInterface.is_parameter(sys::AbstractSystem, sym)
@@ -1175,7 +1175,6 @@ end
 
 namespace_variables(sys::AbstractSystem) = unknowns(sys, unknowns(sys))
 namespace_parameters(sys::AbstractSystem) = parameters(sys, parameters(sys))
-namespace_controls(sys::AbstractSystem) = controls(sys, controls(sys))
 
 function namespace_defaults(sys)
     defs = defaults(sys)
@@ -1557,12 +1556,6 @@ end
 # required in `src/connectors.jl:437`
 parameters(_) = []
 
-function controls(sys::AbstractSystem)
-    ctrls = get_ctrls(sys)
-    systems = get_systems(sys)
-    isempty(systems) ? ctrls : [ctrls; reduce(vcat, namespace_controls.(systems))]
-end
-
 """
 $(TYPEDSIGNATURES)
 
@@ -1783,19 +1776,6 @@ function isaffine(sys::AbstractSystem)
     all(isaffine(r, unknowns(sys)) for r in rhs)
 end
 
-"""
-$(SIGNATURES)
-
-Return a list of actual unknowns needed to be solved by solvers.
-"""
-function solved_unknowns(sys::AbstractSystem)
-    sts = unknowns(sys)
-    if has_solved_unknowns(sys)
-        sts = something(get_solved_unknowns(sys), sts)
-    end
-    return sts
-end
-
 ###
 ### System utils
 ###
@@ -1988,18 +1968,6 @@ end
 
 Base.write(io::IO, sys::AbstractSystem) = write(io, readable_code(toexpr(sys)))
 
-function get_or_construct_tearing_state(sys)
-    if has_tearing_state(sys)
-        state = get_tearing_state(sys)
-        if state === nothing
-            state = TearingState(sys)
-        end
-    else
-        state = nothing
-    end
-    state
-end
-
 """
     n_expanded_connection_equations(sys::AbstractSystem)
 
@@ -2135,15 +2103,6 @@ function Base.show(
     return nothing
 end
 
-function Graphs.incidence_matrix(sys)
-    if has_torn_matching(sys) && has_tearing_state(sys)
-        state = get_tearing_state(sys)
-        incidence_matrix(state.structure.graph, Num(Sym{Real}(:×)))
-    else
-        return nothing
-    end
-end
-
 function split_assign(expr)
     if !(expr isa Expr && expr.head === :(=) && expr.args[2].head === :call)
         throw(ArgumentError("expression should be of the form `sys = foo(a, b)`"))

src/systems/index_cache.jl

@@ -64,7 +64,7 @@ struct IndexCache
 end
 
 function IndexCache(sys::AbstractSystem)
-    unks = solved_unknowns(sys)
+    unks = unknowns(sys)
     unk_idxs = UnknownIndexMap()
     symbol_to_variable = Dict{Symbol, SymbolicParam}()