fix: update initials in remake with non-symbolic u0 and symbolic p

Author: AayushSabharwal

src/systems/nonlinear/initializesystem.jl

@@ -655,8 +655,10 @@ end
 function SciMLBase.late_binding_update_u0_p(
         prob, sys::AbstractSystem, u0, p, t0, newu0, newp)
     u0 === missing && return newu0, (p === missing ? copy(newp) : newp)
+    # non-symbolic u0 updates initials...
     if !(eltype(u0) <: Pair)
-        p === missing || return newu0, newp
+        # if `p` is not provided or is symbolic
+        p === missing || eltype(p) <: Pair || return newu0, newp
         newu0 === nothing && return newu0, newp
         newp = p === missing ? copy(newp) : newp
         initials, repack, alias = SciMLStructures.canonicalize(

test/initializationsystem.jl

@@ -1483,7 +1483,11 @@ end
     @mtkbuild sys = ODESystem([D(x) ~ -c1 * x + c2 * y, D(y) ~ c1 * x - c2 * y], t)
     prob1 = ODEProblem(sys, [1.0, 2.0], (0.0, 1.0), [c1 => 1.0, c2 => 2.0])
     prob2 = remake(prob1, u0 = [2.0, 3.0])
+    prob3 = remake(prob1, u0 = [2.0, 3.0], p = [c1 => 2.0])
     integ1 = init(prob1, Tsit5())
     integ2 = init(prob2, Tsit5())
+    integ3 = init(prob3, Tsit5())
     @test integ2.u ≈ [2.0, 3.0]
+    @test integ3.u ≈ [2.0, 3.0]
+    @test integ3.ps[c1] ≈ 2.0
 end