keep the collect to expand symbolic broadcast

ChrisRackauckas · ChrisRackauckas · commit 7d2d9dea0607 · 2021-08-04T16:53:50.000-04:00
diff --git a/src/systems/nonlinear/nonlinearsystem.jl b/src/systems/nonlinear/nonlinearsystem.jl
@@ -66,7 +66,7 @@ function NonlinearSystem(eqs, states, ps;
                          connection_type=nothing,
                          )
     # Move things over, but do not touch array expressions
-    eqs = eqs isa Vector{Equation} ? [0 ~ x.rhs - x.lhs for x in eqs] : eqs
+    eqs = [0 ~ x.rhs - x.lhs for x in collect(eqs)]
 
     if !(isempty(default_u0) && isempty(default_p))
         Base.depwarn("`default_u0` and `default_p` are deprecated. Use `defaults` instead.", :NonlinearSystem, force=true)

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ function NonlinearSystem(eqs, states, ps;`
`66`	`66`	`connection_type=nothing,`
`67`	`67`	`)`
`68`	`68`	`# Move things over, but do not touch array expressions`
`69`		`- eqs = eqs isa Vector{Equation} ? [0 ~ x.rhs - x.lhs for x in eqs] : eqs`
	`69`	`+ eqs = [0 ~ x.rhs - x.lhs for x in collect(eqs)]`
`70`	`70`
`71`	`71`	`if !(isempty(default_u0) && isempty(default_p))`
`72`	`72`	Base.depwarn("`default_u0` and `default_p` are deprecated. Use `defaults` instead.", :NonlinearSystem, force=true)