feat: propagate and implement allow_algebraic

Author: AayushSabharwal

src/structural_transformation/partial_state_selection.jl

@@ -345,9 +345,7 @@ function dummy_derivative_graph!(
     end
 
     dummy_derivatives_set = BitSet(dummy_derivatives)
-    if !allow_symbolic
-        make_differential_denominators_unsolvable!(structure, dummy_derivatives_set)
-    end
+    make_differential_denominators_unsolvable!(structure, dummy_derivatives_set)
 
     ret = tearing_with_dummy_derivatives(structure, dummy_derivatives_set)
     if log

src/structural_transformation/symbolics_tearing.jl

@@ -992,12 +992,9 @@ end
     ndims = ndims(arr)
 end
 
-function tearing(state::TearingState; allow_symbolic = false, kwargs...)
-    state.structure.solvable_graph === nothing &&
-        find_solvables!(state; allow_symbolic, kwargs...)
-    if !allow_symbolic
-        make_differential_denominators_unsolvable!(state.structure)
-    end
+function tearing(state::TearingState; kwargs...)
+    state.structure.solvable_graph === nothing && find_solvables!(state; kwargs...)
+    make_differential_denominators_unsolvable!(state.structure)
     complete!(state.structure)
     tearing_with_dummy_derivatives(state.structure, ())
 end

src/systems/systemstructure.jl

@@ -719,10 +719,8 @@ function _structural_simplify!(state::TearingState, io; simplify = false,
         sys = ModelingToolkit.dummy_derivative(
             sys, state; simplify, mm, check_consistency, allow_symbolic, kwargs...)
     elseif fully_determined
-        var_eq_matching = pantelides!(state; finalize = false, allow_symbolic, kwargs...)
-        if !allow_symbolic
-            StructuralTransformations.make_differential_denominators_unsolvable!(state.structure)
-        end
+        var_eq_matching = pantelides!(state; finalize = false, kwargs...)
+        StructuralTransformations.make_differential_denominators_unsolvable!(state.structure)
         sys = pantelides_reassemble(state, var_eq_matching)
         state = TearingState(sys)
         sys, mm = ModelingToolkit.alias_elimination!(state; allow_symbolic, kwargs...)